You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "woonsan (via GitHub)" <gi...@apache.org> on 2023/08/02 06:10:11 UTC
[GitHub] [commons-vfs] woonsan opened a new pull request, #409: VFS-841: copying Jackrabbit standalone Main class not to depend on wh…
woonsan opened a new pull request, #409:
URL: https://github.com/apache/commons-vfs/pull/409
…at's not supposed to be exposed by Jackrabbit2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #409: VFS-841: copying Jackrabbit standalone Main class not to depend on wh…
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #409:
URL: https://github.com/apache/commons-vfs/pull/409#issuecomment-1662062588
@woonsan
Thank you for the PR
Run 'mvn' before you push to catch these build failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] woonsan commented on pull request #409: VFS-841: copying Jackrabbit standalone Main class not to depend on wh…
Posted by "woonsan (via GitHub)" <gi...@apache.org>.
woonsan commented on PR #409:
URL: https://github.com/apache/commons-vfs/pull/409#issuecomment-1724602647
@garydgregory , sorry for late. I will update this by the end of this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #409: VFS-841: copying Jackrabbit standalone Main class not to depend on wh…
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #409:
URL: https://github.com/apache/commons-vfs/pull/409#issuecomment-1724613325
> @garydgregory , sorry for late. I will update this by the end of this week.
TY!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] woonsan commented on pull request #409: VFS-841: copying Jackrabbit standalone Main class not to depend on wh…
Posted by "woonsan (via GitHub)" <gi...@apache.org>.
woonsan commented on PR #409:
URL: https://github.com/apache/commons-vfs/pull/409#issuecomment-1725040975
@garydgregory , it seems good now to be reviewed.
Thanks!
Woonsan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] woonsan commented on pull request #409: VFS-841: copying Jackrabbit standalone Main class not to depend on wh…
Posted by "woonsan (via GitHub)" <gi...@apache.org>.
woonsan commented on PR #409:
URL: https://github.com/apache/commons-vfs/pull/409#issuecomment-1712962169
Hi @garydgregory ,
Yes, I think so. The Jackrabbit team believes that the Main class actually needs to be in standalone, not standalone-components and other projects such as commons-vfs2 need to just copy it. So they asked me to do this. ;-)
Kind regards,
Woonsan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #409: VFS-841: copying Jackrabbit standalone Main class not to depend on wh…
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #409:
URL: https://github.com/apache/commons-vfs/pull/409#issuecomment-1713671657
Hi @woonsan
Understood. All we need is for this PR not to break the build ;-) Would you please update this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #409: VFS-841: copying Jackrabbit standalone Main class not to depend on wh…
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #409:
URL: https://github.com/apache/commons-vfs/pull/409#issuecomment-1711766011
Hi @woonsan
Is this still needed now that we did "Bump jackrabbit2.version from 2.20.11 to 2.20.12" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] garydgregory merged pull request #409: VFS-841: copying Jackrabbit standalone Main class not to depend on wh…
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #409:
URL: https://github.com/apache/commons-vfs/pull/409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-vfs] garydgregory commented on pull request #409: VFS-841: copying Jackrabbit standalone Main class not to depend on wh…
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #409:
URL: https://github.com/apache/commons-vfs/pull/409#issuecomment-1722489012
@woonsan
Ping 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org