You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by Mareena Fernando <ma...@gmail.com> on 2017/07/24 18:27:04 UTC
[JMETER iISSUE #53277]
Hello Emilian,
As you told me to logging to detect the situation, I try to do it. There
was no separate option as 'Login'. So but I did was, I just entered the
'name' and the 'value' and then clicked the 'add' button. And again I added
the same name and same value, But there was no replacement. Is this the
thing what you meant by logging?
Thank you.
Re: [JMETER iISSUE #53277]
Posted by Mareena Fernando <ma...@gmail.com>.
Hi,
I know this is not simple. And also I have already started to look into
another bug. Thank you so much.
Thank you.
On Wed, Sep 27, 2017 at 10:12 PM, Philippe Mouawad <
philippe.mouawad@gmail.com> wrote:
> Hello,
> I think everything is explained here:
>
> - http://jmeter.apache.org/building.html
> - https://github.com/apache/jmeter#build-instructions
>
> I think this bug is not the simplest one to fix , I would suggest you start
> with a bug that you are able to reproduce through JUnit or a sample Test
> plan.
>
> Regards
>
> On Wed, Sep 27, 2017 at 8:43 AM, Mareena Fernando <ma...@gmail.com>
> wrote:
>
> > Hi,
> >
> > In order to fix this bug I replace the HashMap with an IdentityHashMap as
> > mentioned in the description. An It was build successfully. Could anyone
> > please tell me how to check whether bug is fix or not?
> > And there were two commands to run and verify before doing the pull
> > request. When I ran the "ant package-and-check" command , it failed both
> > original source code and changed code (code one I replaced with
> > IdentityHashMap). Why this is happening? Please give me some help.
> >
> > Thank you.
> >
> >
> > On Fri, Jul 28, 2017 at 2:32 PM, Mareena Fernando <mareena.fer@gmail.com
> >
> > wrote:
> >
> > > Hello Emilian,
> > >
> > > The #53277 issue seemed to be somewhat understandable. When I was
> reading
> > > the issue I felt like replacing the HashMap with the IdentityHashMap
> > would
> > > be an effective solution for this issue. So that I am still studying
> the
> > > code. But first thing I have to do is, reproducing the error. For that
> I
> > > followed steps that I mentioned in the first mail.
> > >
> > > Thank you.
> > >
> > > On Thu, Jul 27, 2017 at 2:25 PM, Emilian Bold <em...@gmail.com>
> > > wrote:
> > >
> > >> I believe it would be better if you would explain instead what are you
> > >> trying to accomplish.
> > >>
> > >> Why did you pick #53277 and how do you plan on approaching it?
> > >>
> > >> --emi
> > >>
> > >>
> > >> On Thu, Jul 27, 2017 at 11:41 AM, Mareena Fernando
> > >> <ma...@gmail.com> wrote:
> > >> > Hello Emilian,
> > >> >
> > >> > Could you explain more about logger [1] . It's not much clear what
> you
> > >> have
> > >> > said in the previous mail.]
> > >> >
> > >> > Thank you.
> > >> >
> > >> > On Tue, Jul 25, 2017 at 11:06 AM, Emilian Bold <
> > emilian.bold@gmail.com>
> > >> > wrote:
> > >> >
> > >> >> By logging I meant use the logger [1] to save potential situations
> > >> >> where different items that are actually equal are replaced. How you
> > >> >> detect such a situation would be interesting to figure out.
> > >> >>
> > >> >> 1. https://docs.oracle.com/javase/7/docs/api/java/util/
> > >> >> logging/Logger.html#info(java.lang.String)
> > >> >>
> > >> >> PS: Don't start new email threads to continue a discussion. If you
> > >> >> reply to the last email in the previous thread they will all stay
> > >> >> grouped. I see you have 3 threads started for #53277.
> > >> >>
> > >> >> --emi
> > >> >>
> > >> >>
> > >> >> On Mon, Jul 24, 2017 at 9:27 PM, Mareena Fernando <
> > >> mareena.fer@gmail.com>
> > >> >> wrote:
> > >> >> > Hello Emilian,
> > >> >> >
> > >> >> > As you told me to logging to detect the situation, I try to do
> it.
> > >> There
> > >> >> > was no separate option as 'Login'. So but I did was, I just
> entered
> > >> the
> > >> >> > 'name' and the 'value' and then clicked the 'add' button. And
> > again I
> > >> >> added
> > >> >> > the same name and same value, But there was no replacement. Is
> this
> > >> the
> > >> >> > thing what you meant by logging?
> > >> >> >
> > >> >> > Thank you.
> > >> >>
> > >>
> > >
> > >
> >
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
Re: [JMETER iISSUE #53277]
Posted by Philippe Mouawad <ph...@gmail.com>.
Hello,
I think everything is explained here:
- http://jmeter.apache.org/building.html
- https://github.com/apache/jmeter#build-instructions
I think this bug is not the simplest one to fix , I would suggest you start
with a bug that you are able to reproduce through JUnit or a sample Test
plan.
Regards
On Wed, Sep 27, 2017 at 8:43 AM, Mareena Fernando <ma...@gmail.com>
wrote:
> Hi,
>
> In order to fix this bug I replace the HashMap with an IdentityHashMap as
> mentioned in the description. An It was build successfully. Could anyone
> please tell me how to check whether bug is fix or not?
> And there were two commands to run and verify before doing the pull
> request. When I ran the "ant package-and-check" command , it failed both
> original source code and changed code (code one I replaced with
> IdentityHashMap). Why this is happening? Please give me some help.
>
> Thank you.
>
>
> On Fri, Jul 28, 2017 at 2:32 PM, Mareena Fernando <ma...@gmail.com>
> wrote:
>
> > Hello Emilian,
> >
> > The #53277 issue seemed to be somewhat understandable. When I was reading
> > the issue I felt like replacing the HashMap with the IdentityHashMap
> would
> > be an effective solution for this issue. So that I am still studying the
> > code. But first thing I have to do is, reproducing the error. For that I
> > followed steps that I mentioned in the first mail.
> >
> > Thank you.
> >
> > On Thu, Jul 27, 2017 at 2:25 PM, Emilian Bold <em...@gmail.com>
> > wrote:
> >
> >> I believe it would be better if you would explain instead what are you
> >> trying to accomplish.
> >>
> >> Why did you pick #53277 and how do you plan on approaching it?
> >>
> >> --emi
> >>
> >>
> >> On Thu, Jul 27, 2017 at 11:41 AM, Mareena Fernando
> >> <ma...@gmail.com> wrote:
> >> > Hello Emilian,
> >> >
> >> > Could you explain more about logger [1] . It's not much clear what you
> >> have
> >> > said in the previous mail.]
> >> >
> >> > Thank you.
> >> >
> >> > On Tue, Jul 25, 2017 at 11:06 AM, Emilian Bold <
> emilian.bold@gmail.com>
> >> > wrote:
> >> >
> >> >> By logging I meant use the logger [1] to save potential situations
> >> >> where different items that are actually equal are replaced. How you
> >> >> detect such a situation would be interesting to figure out.
> >> >>
> >> >> 1. https://docs.oracle.com/javase/7/docs/api/java/util/
> >> >> logging/Logger.html#info(java.lang.String)
> >> >>
> >> >> PS: Don't start new email threads to continue a discussion. If you
> >> >> reply to the last email in the previous thread they will all stay
> >> >> grouped. I see you have 3 threads started for #53277.
> >> >>
> >> >> --emi
> >> >>
> >> >>
> >> >> On Mon, Jul 24, 2017 at 9:27 PM, Mareena Fernando <
> >> mareena.fer@gmail.com>
> >> >> wrote:
> >> >> > Hello Emilian,
> >> >> >
> >> >> > As you told me to logging to detect the situation, I try to do it.
> >> There
> >> >> > was no separate option as 'Login'. So but I did was, I just entered
> >> the
> >> >> > 'name' and the 'value' and then clicked the 'add' button. And
> again I
> >> >> added
> >> >> > the same name and same value, But there was no replacement. Is this
> >> the
> >> >> > thing what you meant by logging?
> >> >> >
> >> >> > Thank you.
> >> >>
> >>
> >
> >
>
--
Cordialement.
Philippe Mouawad.
Re: [JMETER iISSUE #53277]
Posted by Mareena Fernando <ma...@gmail.com>.
Hi,
In order to fix this bug I replace the HashMap with an IdentityHashMap as
mentioned in the description. An It was build successfully. Could anyone
please tell me how to check whether bug is fix or not?
And there were two commands to run and verify before doing the pull
request. When I ran the "ant package-and-check" command , it failed both
original source code and changed code (code one I replaced with
IdentityHashMap). Why this is happening? Please give me some help.
Thank you.
On Fri, Jul 28, 2017 at 2:32 PM, Mareena Fernando <ma...@gmail.com>
wrote:
> Hello Emilian,
>
> The #53277 issue seemed to be somewhat understandable. When I was reading
> the issue I felt like replacing the HashMap with the IdentityHashMap would
> be an effective solution for this issue. So that I am still studying the
> code. But first thing I have to do is, reproducing the error. For that I
> followed steps that I mentioned in the first mail.
>
> Thank you.
>
> On Thu, Jul 27, 2017 at 2:25 PM, Emilian Bold <em...@gmail.com>
> wrote:
>
>> I believe it would be better if you would explain instead what are you
>> trying to accomplish.
>>
>> Why did you pick #53277 and how do you plan on approaching it?
>>
>> --emi
>>
>>
>> On Thu, Jul 27, 2017 at 11:41 AM, Mareena Fernando
>> <ma...@gmail.com> wrote:
>> > Hello Emilian,
>> >
>> > Could you explain more about logger [1] . It's not much clear what you
>> have
>> > said in the previous mail.]
>> >
>> > Thank you.
>> >
>> > On Tue, Jul 25, 2017 at 11:06 AM, Emilian Bold <em...@gmail.com>
>> > wrote:
>> >
>> >> By logging I meant use the logger [1] to save potential situations
>> >> where different items that are actually equal are replaced. How you
>> >> detect such a situation would be interesting to figure out.
>> >>
>> >> 1. https://docs.oracle.com/javase/7/docs/api/java/util/
>> >> logging/Logger.html#info(java.lang.String)
>> >>
>> >> PS: Don't start new email threads to continue a discussion. If you
>> >> reply to the last email in the previous thread they will all stay
>> >> grouped. I see you have 3 threads started for #53277.
>> >>
>> >> --emi
>> >>
>> >>
>> >> On Mon, Jul 24, 2017 at 9:27 PM, Mareena Fernando <
>> mareena.fer@gmail.com>
>> >> wrote:
>> >> > Hello Emilian,
>> >> >
>> >> > As you told me to logging to detect the situation, I try to do it.
>> There
>> >> > was no separate option as 'Login'. So but I did was, I just entered
>> the
>> >> > 'name' and the 'value' and then clicked the 'add' button. And again I
>> >> added
>> >> > the same name and same value, But there was no replacement. Is this
>> the
>> >> > thing what you meant by logging?
>> >> >
>> >> > Thank you.
>> >>
>>
>
>
Re: [JMETER iISSUE #53277]
Posted by Mareena Fernando <ma...@gmail.com>.
Hello Emilian,
The #53277 issue seemed to be somewhat understandable. When I was reading
the issue I felt like replacing the HashMap with the IdentityHashMap would
be an effective solution for this issue. So that I am still studying the
code. But first thing I have to do is, reproducing the error. For that I
followed steps that I mentioned in the first mail.
Thank you.
On Thu, Jul 27, 2017 at 2:25 PM, Emilian Bold <em...@gmail.com>
wrote:
> I believe it would be better if you would explain instead what are you
> trying to accomplish.
>
> Why did you pick #53277 and how do you plan on approaching it?
>
> --emi
>
>
> On Thu, Jul 27, 2017 at 11:41 AM, Mareena Fernando
> <ma...@gmail.com> wrote:
> > Hello Emilian,
> >
> > Could you explain more about logger [1] . It's not much clear what you
> have
> > said in the previous mail.]
> >
> > Thank you.
> >
> > On Tue, Jul 25, 2017 at 11:06 AM, Emilian Bold <em...@gmail.com>
> > wrote:
> >
> >> By logging I meant use the logger [1] to save potential situations
> >> where different items that are actually equal are replaced. How you
> >> detect such a situation would be interesting to figure out.
> >>
> >> 1. https://docs.oracle.com/javase/7/docs/api/java/util/
> >> logging/Logger.html#info(java.lang.String)
> >>
> >> PS: Don't start new email threads to continue a discussion. If you
> >> reply to the last email in the previous thread they will all stay
> >> grouped. I see you have 3 threads started for #53277.
> >>
> >> --emi
> >>
> >>
> >> On Mon, Jul 24, 2017 at 9:27 PM, Mareena Fernando <
> mareena.fer@gmail.com>
> >> wrote:
> >> > Hello Emilian,
> >> >
> >> > As you told me to logging to detect the situation, I try to do it.
> There
> >> > was no separate option as 'Login'. So but I did was, I just entered
> the
> >> > 'name' and the 'value' and then clicked the 'add' button. And again I
> >> added
> >> > the same name and same value, But there was no replacement. Is this
> the
> >> > thing what you meant by logging?
> >> >
> >> > Thank you.
> >>
>
Re: [JMETER iISSUE #53277]
Posted by Emilian Bold <em...@gmail.com>.
I believe it would be better if you would explain instead what are you
trying to accomplish.
Why did you pick #53277 and how do you plan on approaching it?
--emi
On Thu, Jul 27, 2017 at 11:41 AM, Mareena Fernando
<ma...@gmail.com> wrote:
> Hello Emilian,
>
> Could you explain more about logger [1] . It's not much clear what you have
> said in the previous mail.]
>
> Thank you.
>
> On Tue, Jul 25, 2017 at 11:06 AM, Emilian Bold <em...@gmail.com>
> wrote:
>
>> By logging I meant use the logger [1] to save potential situations
>> where different items that are actually equal are replaced. How you
>> detect such a situation would be interesting to figure out.
>>
>> 1. https://docs.oracle.com/javase/7/docs/api/java/util/
>> logging/Logger.html#info(java.lang.String)
>>
>> PS: Don't start new email threads to continue a discussion. If you
>> reply to the last email in the previous thread they will all stay
>> grouped. I see you have 3 threads started for #53277.
>>
>> --emi
>>
>>
>> On Mon, Jul 24, 2017 at 9:27 PM, Mareena Fernando <ma...@gmail.com>
>> wrote:
>> > Hello Emilian,
>> >
>> > As you told me to logging to detect the situation, I try to do it. There
>> > was no separate option as 'Login'. So but I did was, I just entered the
>> > 'name' and the 'value' and then clicked the 'add' button. And again I
>> added
>> > the same name and same value, But there was no replacement. Is this the
>> > thing what you meant by logging?
>> >
>> > Thank you.
>>
Re: [JMETER iISSUE #53277]
Posted by Mareena Fernando <ma...@gmail.com>.
Hello Emilian,
Could you explain more about logger [1] . It's not much clear what you have
said in the previous mail.]
Thank you.
On Tue, Jul 25, 2017 at 11:06 AM, Emilian Bold <em...@gmail.com>
wrote:
> By logging I meant use the logger [1] to save potential situations
> where different items that are actually equal are replaced. How you
> detect such a situation would be interesting to figure out.
>
> 1. https://docs.oracle.com/javase/7/docs/api/java/util/
> logging/Logger.html#info(java.lang.String)
>
> PS: Don't start new email threads to continue a discussion. If you
> reply to the last email in the previous thread they will all stay
> grouped. I see you have 3 threads started for #53277.
>
> --emi
>
>
> On Mon, Jul 24, 2017 at 9:27 PM, Mareena Fernando <ma...@gmail.com>
> wrote:
> > Hello Emilian,
> >
> > As you told me to logging to detect the situation, I try to do it. There
> > was no separate option as 'Login'. So but I did was, I just entered the
> > 'name' and the 'value' and then clicked the 'add' button. And again I
> added
> > the same name and same value, But there was no replacement. Is this the
> > thing what you meant by logging?
> >
> > Thank you.
>
Re: [JMETER iISSUE #53277]
Posted by Emilian Bold <em...@gmail.com>.
By logging I meant use the logger [1] to save potential situations
where different items that are actually equal are replaced. How you
detect such a situation would be interesting to figure out.
1. https://docs.oracle.com/javase/7/docs/api/java/util/logging/Logger.html#info(java.lang.String)
PS: Don't start new email threads to continue a discussion. If you
reply to the last email in the previous thread they will all stay
grouped. I see you have 3 threads started for #53277.
--emi
On Mon, Jul 24, 2017 at 9:27 PM, Mareena Fernando <ma...@gmail.com> wrote:
> Hello Emilian,
>
> As you told me to logging to detect the situation, I try to do it. There
> was no separate option as 'Login'. So but I did was, I just entered the
> 'name' and the 'value' and then clicked the 'add' button. And again I added
> the same name and same value, But there was no replacement. Is this the
> thing what you meant by logging?
>
> Thank you.