You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "kezhenxu94 (GitHub)" <gi...@apache.org> on 2019/01/31 07:50:45 UTC
[GitHub] [incubator-dubbo-ops] kezhenxu94 opened pull request #286:
feature: navigation between services and tests. Fixes #285
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/286 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] nzomkxia commented on issue #286:
feature: navigation between services and tests. Fixes #285
Posted by "nzomkxia (GitHub)" <gi...@apache.org>.
> And I suggest splitting the i18n language file to individual files acccording to different modules, because:
>
> * there are chances that different messages with same key are required in different modules
> * it would be more contextual for people who wants to localize to their language
>
> @nzomkxia WDYT? If it's good, I'll open another issue.
sorry for the late reply, I think it's a good advice, please open another issue
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/286 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] kezhenxu94 commented on issue #286:
feature: navigation between services and tests. Fixes #285
Posted by "kezhenxu94 (GitHub)" <gi...@apache.org>.
And I suggest splitting the i18n language file to individual files acccording different modules, because:
- there are chances that different messages with same key are required in different modules
- it would be more contextual for people who wants to localize to their language
@nzomkxia WDYT? If it's good, I'll open another issue.
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/286 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #286:
feature: navigation between services and tests. Fixes #285
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/286?src=pr&el=h1) Report
> Merging [#286](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/286?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/9bb1f42358654b6327c7e3c96f9c975c24a1052d?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/286?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #286 +/- ##
=========================================
Coverage 23.2% 23.2%
Complexity 345 345
=========================================
Files 91 91
Lines 3650 3650
Branches 570 570
=========================================
Hits 847 847
Misses 2712 2712
Partials 91 91
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/286?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/286?src=pr&el=footer). Last update [9bb1f42...7000a14](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/286?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/286 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] nzomkxia closed pull request #286:
feature: navigation between services and tests. Fixes #285
Posted by "nzomkxia (GitHub)" <gi...@apache.org>.
[ pull request closed by nzomkxia ]
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/286 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #286:
feature: navigation between services and tests. Fixes #285
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/286?src=pr&el=h1) Report
> Merging [#286](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/286?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/87669fdb75323026a4d7b078d82fe02dbfd94ef5?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/286?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #286 +/- ##
==========================================
Coverage 19.37% 19.37%
Complexity 289 289
==========================================
Files 91 91
Lines 3639 3639
Branches 566 566
==========================================
Hits 705 705
Misses 2859 2859
Partials 75 75
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/286?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/286?src=pr&el=footer). Last update [87669fd...169eb83](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/286?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/286 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #286:
feature: navigation between services and tests. Fixes #285
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/286?src=pr&el=h1) Report
> Merging [#286](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/286?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/9bb1f42358654b6327c7e3c96f9c975c24a1052d?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/286?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #286 +/- ##
=========================================
Coverage 23.2% 23.2%
Complexity 345 345
=========================================
Files 91 91
Lines 3650 3650
Branches 570 570
=========================================
Hits 847 847
Misses 2712 2712
Partials 91 91
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/286?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/286?src=pr&el=footer). Last update [9bb1f42...d7e6d1c](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/286?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/286 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #286:
feature: navigation between services and tests. Fixes #285
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/286?src=pr&el=h1) Report
> Merging [#286](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/286?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/9bb1f42358654b6327c7e3c96f9c975c24a1052d?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/286?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #286 +/- ##
=========================================
Coverage 23.2% 23.2%
Complexity 345 345
=========================================
Files 91 91
Lines 3650 3650
Branches 570 570
=========================================
Hits 847 847
Misses 2712 2712
Partials 91 91
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/286?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/286?src=pr&el=footer). Last update [9bb1f42...7000a14](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/286?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/286 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] kezhenxu94 commented on issue #286:
feature: navigation between services and tests. Fixes #285
Posted by "kezhenxu94 (GitHub)" <gi...@apache.org>.
And I suggest splitting the i18n language file to individual files acccording to different modules, because:
- there are chances that different messages with same key are required in different modules
- it would be more contextual for people who wants to localize to their language
@nzomkxia WDYT? If it's good, I'll open another issue.
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/286 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org