You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/26 20:39:08 UTC

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #25321: Use simple Json in Dataset & DatasetEvent extra field

ephraimbuddy commented on code in PR #25321:
URL: https://github.com/apache/airflow/pull/25321#discussion_r930391709


##########
airflow/migrations/versions/0114_2_4_0_add_dataset_model.py:
##########
@@ -55,7 +55,7 @@ def _create_dataset_table():
             ),
             nullable=False,
         ),
-        sa.Column('extra', ExtendedJSON, nullable=True),
+        sa.Column('extra', sqlalchemy_jsonfield.JSONField(json=json), nullable=True),

Review Comment:
   I think you mean the `{}` in the REST API? That's just because of the JsonObjectField used. It returns `{}` if the value is null and I think it's ok. 
   The field is still nullable at the DB level, just empty dictionary at the REST API. I can work the REST API to return None if it's preferred?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org