You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/12/07 19:23:47 UTC
[GitHub] [cordova-android] tiagoappereira opened a new pull request #1384: fix: replace & characters in project name to avoid error on platform add
tiagoappereira opened a new pull request #1384:
URL: https://github.com/apache/cordova-android/pull/1384
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
Error on `cordova platform add` when the Cordova app name contains the character `&`. The issue occurs when parsing the `strings.xml` file. The issue was introduced on cordova-android 10.1.0
<!-- If it fixes an open issue, please link to the issue here. -->
Fixes https://github.com/apache/cordova-android/issues/1380
### Description
<!-- Describe your changes in detail -->
Simply replaces the `&` characters in the project name (if present) by an `_`.
### Testing
<!-- Please describe in detail how you tested your changes. -->
`npm test` and project creation successful
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu commented on pull request #1384: fix: escape strings.xml app name
Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #1384:
URL: https://github.com/apache/cordova-android/pull/1384#issuecomment-1005793559
Here is what lodash escape does, just for additional details:
```
'&': '&',
'<': '<',
'>': '>',
'"': '"',
"'": ''',
'`': '`'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu edited a comment on pull request #1384: fix: escape strings.xml app name
Posted by GitBox <gi...@apache.org>.
erisu edited a comment on pull request #1384:
URL: https://github.com/apache/cordova-android/pull/1384#issuecomment-1005765219
We have been removing lodash from our dependencies because of the vuln. report frequencies.
I have discussed with others on dropping `@netflix/nerror` because they neglected to update their package over 2 years now and even with a PR open fixing their issues.
https://github.com/Netflix/nerror/pull/18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #1384: fix: escape strings.xml app name
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1384:
URL: https://github.com/apache/cordova-android/pull/1384#issuecomment-989832458
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1384?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1384](https://codecov.io/gh/apache/cordova-android/pull/1384?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (64ed3b7) into [master](https://codecov.io/gh/apache/cordova-android/commit/a1ed1c0af7c6267f47e580e8850295202692f4ea?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a1ed1c0) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1384?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1384 +/- ##
==========================================
+ Coverage 73.15% 73.17% +0.01%
==========================================
Files 21 21
Lines 1643 1644 +1
==========================================
+ Hits 1202 1203 +1
Misses 441 441
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1384?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/1384/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2NyZWF0ZS5qcw==) | `94.28% <100.00%> (+0.04%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1384?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1384?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a1ed1c0...64ed3b7](https://codecov.io/gh/apache/cordova-android/pull/1384?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter commented on pull request #1384: fix: escape strings.xml app name
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1384:
URL: https://github.com/apache/cordova-android/pull/1384#issuecomment-989832458
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1384?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1384](https://codecov.io/gh/apache/cordova-android/pull/1384?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (64ed3b7) into [master](https://codecov.io/gh/apache/cordova-android/commit/a1ed1c0af7c6267f47e580e8850295202692f4ea?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a1ed1c0) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1384?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1384 +/- ##
==========================================
+ Coverage 73.15% 73.17% +0.01%
==========================================
Files 21 21
Lines 1643 1644 +1
==========================================
+ Hits 1202 1203 +1
Misses 441 441
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1384?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/1384/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2NyZWF0ZS5qcw==) | `94.28% <100.00%> (+0.04%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1384?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1384?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a1ed1c0...64ed3b7](https://codecov.io/gh/apache/cordova-android/pull/1384?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] jcesarmobile commented on pull request #1384: fix: escape strings.xml app name
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on pull request #1384:
URL: https://github.com/apache/cordova-android/pull/1384#issuecomment-1005808254
there is some previous conversion somewhere else, because I tested with `'` and `"` and `'` was converted to `\'` and `"` wasn't converted at all.
Note that for them to work in `strings.xml` they have to be `\'` and `\"`, didn't try ` (by work I mean that the app name is displayed on the phone exactly as on the `strings.xml`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek commented on pull request #1384: fix: escape strings.xml app name
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #1384:
URL: https://github.com/apache/cordova-android/pull/1384#issuecomment-1005768452
> We have been removing lodash from our dependencies because of the vuln. report frequencies.
>
> I have discussed with others on dropping `@netflix/nerror` because they neglected to update their package over 2 years now and even with PRs open to resolve some issues.
>
> [Netflix/nerror#18](https://github.com/Netflix/nerror/pull/18)
To add onto this, we can probably solve the same issue using the JS native method [encodeURIComponent](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent) so that we can avoid introducing another lodash dependency. I'm pretty sure the method exists in NodeJS environments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] jcesarmobile commented on pull request #1384: fix: escape strings.xml app name
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on pull request #1384:
URL: https://github.com/apache/cordova-android/pull/1384#issuecomment-1005995098
I found where the `'` is converted to `\'`, is not done by lodash
https://github.com/apache/cordova-android/blob/09c75237d9348a944b4946ccb31d2dee90330ce4/lib/prepare.js#L266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek edited a comment on pull request #1384: fix: escape strings.xml app name
Posted by GitBox <gi...@apache.org>.
breautek edited a comment on pull request #1384:
URL: https://github.com/apache/cordova-android/pull/1384#issuecomment-1005768452
> We have been removing lodash from our dependencies because of the vuln. report frequencies.
>
> I have discussed with others on dropping `@netflix/nerror` because they neglected to update their package over 2 years now and even with PRs open to resolve some issues.
>
> [Netflix/nerror#18](https://github.com/Netflix/nerror/pull/18)
To add onto this, we can probably solve the same issue using the JS native method [encodeURIComponent](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent) so that we can avoid introducing another lodash dependency in the code. I'm pretty sure the method exists in NodeJS environments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu merged pull request #1384: fix: escape strings.xml app name
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #1384:
URL: https://github.com/apache/cordova-android/pull/1384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #1384: fix: escape strings.xml app name
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1384:
URL: https://github.com/apache/cordova-android/pull/1384#issuecomment-989832458
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1384?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1384](https://codecov.io/gh/apache/cordova-android/pull/1384?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (64ed3b7) into [master](https://codecov.io/gh/apache/cordova-android/commit/a1ed1c0af7c6267f47e580e8850295202692f4ea?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a1ed1c0) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1384?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1384 +/- ##
==========================================
+ Coverage 73.15% 73.17% +0.01%
==========================================
Files 21 21
Lines 1643 1644 +1
==========================================
+ Hits 1202 1203 +1
Misses 441 441
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1384?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/1384/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2NyZWF0ZS5qcw==) | `94.28% <100.00%> (+0.04%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1384?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1384?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a1ed1c0...64ed3b7](https://codecov.io/gh/apache/cordova-android/pull/1384?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu commented on pull request #1384: fix: escape strings.xml app name
Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #1384:
URL: https://github.com/apache/cordova-android/pull/1384#issuecomment-1005765219
We have been removing lodash from our dependencies because of the vuln. report frequencies.
I have discussed with others on dropping `@netflix/nerror` because they neglected to update their package over 2 years now and even with PRs open to resolve some issues.
https://github.com/Netflix/nerror/pull/18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] jcesarmobile commented on pull request #1384: fix: escape strings.xml app name
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on pull request #1384:
URL: https://github.com/apache/cordova-android/pull/1384#issuecomment-1005778841
`encodeURIComponent` won't work because it scapes `<Incredible&App>` to `%3CIncredible%26App%3E`, which is not valid on the `strings.xml`.
I solved a similar problem in Capacitor using replace like this
https://github.com/ionic-team/capacitor/pull/5325/files#diff-ed3a1ffe6172324599c40aaeea6832beab33815ec5c28ba7f87e1a37fb55fae1R74-R78
note that it doesn't include `>` replacement because it wasn't needed in Capacitor, but might still be needed in Cordova as it looks like it does some previous conversion
also note that it includes `"`, which is not escaped by lodash
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] jcesarmobile commented on pull request #1384: fix: escape strings.xml app name
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on pull request #1384:
URL: https://github.com/apache/cordova-android/pull/1384#issuecomment-1005759552
It's already being installed because it's a dependency of other 3 dependencies.
As you can see, the package-lock.json doesn't change because it's already installed.
I would be in favor of not installing lodash, but that would mean updating a lot of our dependencies (including cordova-common as it depends on @netflix/nerror which depends on lodash)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] jcesarmobile edited a comment on pull request #1384: fix: escape strings.xml app name
Posted by GitBox <gi...@apache.org>.
jcesarmobile edited a comment on pull request #1384:
URL: https://github.com/apache/cordova-android/pull/1384#issuecomment-1005808254
there is some previous conversion somewhere else, because I tested with `'` and `"` and `'` was converted to `\'` and `"` wasn't converted at all.
Note that for them to work in `strings.xml` they have to be `\'` and `\"`, didn't try ``` (by work I mean that the app name is displayed on the phone exactly as on the `strings.xml`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] dpogue commented on pull request #1384: fix: replace & characters in project name to avoid error on platform add
Posted by GitBox <gi...@apache.org>.
dpogue commented on pull request #1384:
URL: https://github.com/apache/cordova-android/pull/1384#issuecomment-988210541
Wouldn't the correct fix be to XML-escape the `&` (or other special characters like `<` and `>`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org