You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/14 17:01:55 UTC
[GitHub] [pulsar] rdhabalia commented on a change in pull request #14251: [pulsar-broker] provide readable consumer stats time
rdhabalia commented on a change in pull request #14251:
URL: https://github.com/apache/pulsar/pull/14251#discussion_r806054317
##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/stats/ConsumerStatsImpl.java
##########
@@ -84,7 +85,11 @@
@JsonIgnore
private int clientVersionLength;
+ // ignore this json field to skip from stats in future release. replaced with readable #getLastAckedTime().
+ @Deprecated
Review comment:
I think if app requires a calculation then app can always programmatically changes date to timestamp.
##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/stats/ConsumerStatsImpl.java
##########
@@ -84,7 +85,11 @@
@JsonIgnore
private int clientVersionLength;
+ // ignore this json field to skip from stats in future release. replaced with readable #getLastAckedTime().
+ @Deprecated
Review comment:
I think if app requires a calculation then app can always programmatically change date to timestamp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org