You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2014/12/19 07:38:48 UTC

svn commit: r1646630 - /pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/ttf/GlyfSimpleDescript.java

Author: tilman
Date: Fri Dec 19 06:38:48 2014
New Revision: 1646630

URL: http://svn.apache.org/r1646630
Log:
PDFBOX-2576: remove double assignment of field

Modified:
    pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/ttf/GlyfSimpleDescript.java

Modified: pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/ttf/GlyfSimpleDescript.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/ttf/GlyfSimpleDescript.java?rev=1646630&r1=1646629&r2=1646630&view=diff
==============================================================================
--- pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/ttf/GlyfSimpleDescript.java (original)
+++ pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/ttf/GlyfSimpleDescript.java Fri Dec 19 06:38:48 2014
@@ -38,7 +38,7 @@ public class GlyfSimpleDescript extends
     private byte[] flags;
     private short[] xCoordinates;
     private short[] yCoordinates;
-    private int pointCount;
+    private final int pointCount;
 
     /**
      * Constructor.
@@ -63,7 +63,6 @@ public class GlyfSimpleDescript extends
         }
 
         // Simple glyph description
-        endPtsOfContours = new int[numberOfContours];
         endPtsOfContours = bais.readUnsignedShortArray(numberOfContours);
 
         // The last end point index reveals the total number of points
@@ -82,6 +81,7 @@ public class GlyfSimpleDescript extends
     /**
      * {@inheritDoc}
      */
+    @Override
     public int getEndPtOfContours(int i)
     {
         return endPtsOfContours[i];
@@ -90,6 +90,7 @@ public class GlyfSimpleDescript extends
     /**
      * {@inheritDoc}
      */
+    @Override
     public byte getFlags(int i)
     {
         return flags[i];
@@ -98,6 +99,7 @@ public class GlyfSimpleDescript extends
     /**
      * {@inheritDoc}
      */
+    @Override
     public short getXCoordinate(int i)
     {
         return xCoordinates[i];
@@ -106,6 +108,7 @@ public class GlyfSimpleDescript extends
     /**
      * {@inheritDoc}
      */
+    @Override
     public short getYCoordinate(int i)
     {
         return yCoordinates[i];
@@ -114,6 +117,7 @@ public class GlyfSimpleDescript extends
     /**
      * {@inheritDoc}
      */
+    @Override
     public boolean isComposite()
     {
         return false;
@@ -122,6 +126,7 @@ public class GlyfSimpleDescript extends
     /**
      * {@inheritDoc}
      */
+    @Override
     public int getPointCount()
     {
         return pointCount;