[GitHub] [iceberg] danielcweeks commented on pull request #2539: AWS: Make S3URI public

[GitBox <gi...@apache.org>]

danielcweeks commented on pull request #2539:
URL: https://github.com/apache/iceberg/pull/2539#issuecomment-828572473


   Hey, @edgarRd, if I remember correctly, the reason it is currently package is that the `S3URI` implementation covers most common S3 identifiers, but not all (there was some prior discussion about the complexity of this and lack of a good utility with the aws sdkv2 implementation).
   
   I'm thinking at this point that maybe we shouldn't expose the S3URI, but rather push the S3URI reference down into the `BaseS3File` so that we don't expose it at the `S3FileIO` level.
   
   Does that make sense and would that address your use case?
   
   Thanks,
   Dan
   
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org