You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/03/30 19:02:48 UTC
[GitHub] [beam] dpcollins-google opened a new pull request #17221: [BEAM-14129] Perform all file writes in WriteFiles in the background
dpcollins-google opened a new pull request #17221:
URL: https://github.com/apache/beam/pull/17221
This should allow bundles which write to multiple files to write to each of them in parallel, instead of blocking when any of their buffers fill up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17221: [BEAM-14129] Perform all file writes in WriteFiles in the background
Posted by GitBox <gi...@apache.org>.
asf-ci commented on pull request #17221:
URL: https://github.com/apache/beam/pull/17221#issuecomment-1083552054
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] dpcollins-google commented on pull request #17221: [BEAM-14129] Perform all file writes in WriteFiles in the background
Posted by GitBox <gi...@apache.org>.
dpcollins-google commented on pull request #17221:
URL: https://github.com/apache/beam/pull/17221#issuecomment-1085016438
Run Java PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17221: [BEAM-14129] Perform all file writes in WriteFiles in the background
Posted by GitBox <gi...@apache.org>.
asf-ci commented on pull request #17221:
URL: https://github.com/apache/beam/pull/17221#issuecomment-1083551190
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] reuvenlax commented on pull request #17221: [BEAM-14129] Perform all file writes in WriteFiles in the background
Posted by GitBox <gi...@apache.org>.
reuvenlax commented on pull request #17221:
URL: https://github.com/apache/beam/pull/17221#issuecomment-1085053533
Left some comments, but I have questions as to whether this PR is needed. We already GBK by a destination hash, which means it should be exceedingly rare to have multiple destinations in one bundle (only if the hash function collides). Do we have evidence this PR helps?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] dpcollins-google commented on pull request #17221: [BEAM-14129] Perform all file writes in WriteFiles in the background
Posted by GitBox <gi...@apache.org>.
dpcollins-google commented on pull request #17221:
URL: https://github.com/apache/beam/pull/17221#issuecomment-1084989342
Run Java PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] dpcollins-google commented on pull request #17221: [BEAM-14129] Perform all file writes in WriteFiles in the background
Posted by GitBox <gi...@apache.org>.
dpcollins-google commented on pull request #17221:
URL: https://github.com/apache/beam/pull/17221#issuecomment-1083525656
R: @reuvenlax
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org