[jira] Updated: (SCOUT-21) can't configure transport class property using the properties in the factory

["Kurt Stam (JIRA)" <sc...@ws.apache.org>]

     [ http://issues.apache.org/jira/browse/SCOUT-21?page=all ]

Kurt Stam updated SCOUT-21:
---------------------------

    Attachment: sout-21.zip

IMHO the connectionFactoryImpl needs an addition member variable 'transportClass'. Then in createConnection() it can pass this as an argument:

return new ConnectionImpl(queryManager, lifeCycleManager, transportClass, null, maxRows == null ? -1 : maxRows.intValue());

and the ConnectionImpl class can then use it:

if (transportClass!=null) {
    		prop.setProperty(RegistryImpl.TRANSPORT_CLASS_PROPERTY_NAME, transportClass);
    	} else {
    		String transport = System.getProperty(RegistryImpl.TRANSPORT_CLASS_PROPERTY_NAME);
    		if (transport != null) {
    			prop.setProperty(RegistryImpl.TRANSPORT_CLASS_PROPERTY_NAME, transport);
    		}
        }

This patch will prevent the user from having to set this value as a System parameter, as it now can be set as a property in the factory.


See attached files

> can't configure transport class property using the properties in the factory
> ----------------------------------------------------------------------------
>
>                 Key: SCOUT-21
>                 URL: http://issues.apache.org/jira/browse/SCOUT-21
>             Project: Scout
>          Issue Type: Bug
>            Reporter: Kurt Stam
>         Assigned To: Anil Saldhana
>         Attachments: sout-21.zip
>
>
> To create a connection one does:
> // Create the connection, passing it the configuration properties
>             ConnectionFactory factory = ConnectionFactory.newInstance();
>             factory.setProperties(props);
>             connection = factory.createConnection();
> One of the properties can be "scout.proxy.transportClass", however this setting is not used. 
> In org.apache.ws.scout.registry.ConnectionImpl a new Properties is made.. 
> Now I'm forced to use a System parameter.  
> This can't be right. Maybe I'm missing something..

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: scout-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: scout-dev-help@ws.apache.org