[GitHub] [hive] pvargacl commented on a change in pull request #1968: HIVE-24715 Increase bucketId range (amagyar)

[GitBox <gi...@apache.org>]

pvargacl commented on a change in pull request #1968:
URL: https://github.com/apache/hive/pull/1968#discussion_r576280743



##########
File path: ql/src/test/org/apache/hadoop/hive/ql/io/TestBucketCodec.java
##########
@@ -77,13 +77,13 @@ public void testGetBucketCodecVersion1() {
 
   @Test(expected = IllegalArgumentException.class)
   public void testGetBucketCodecVersion1EncodeNegativeBucketId() {
-    BucketCodec.getCodec(1).encode(new AcidOutputFormat.Options(null).bucket(-1).statementId(16));
+    BucketCodec.getCodec(1).encode(new AcidOutputFormat.Options(null).bucket(-1).statementId(16).maxStmtId(BucketCodec.MAX_STATEMENT_ID));

Review comment:
       Why is this needed? This is the default behaviour if maxstatementId was not set, no?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org