[jira] [Commented] (LUCENE-6272) Scorer should not extend PostingsEnum

["Robert Muir (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-6272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329573#comment-14329573 ] 

Robert Muir commented on LUCENE-6272:
-------------------------------------

I think its complicated to change the semantics of freq() at the same time as refactoring the class hierarchy.

freq() and getChildren() are still being discussed here: LUCENE-6229

> Scorer should not extend PostingsEnum
> -------------------------------------
>
>                 Key: LUCENE-6272
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6272
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Alan Woodward
>            Priority: Minor
>         Attachments: LUCENE-6272.patch
>
>
> Scorer currently has to implement a whole bunch of methods that are never called.  The only method that Scorer uses in addition to the methods on DocIdSetIterator is freq(), and as currently implemented this means different things on different Scorers:
> * TermScorer returns its underlying termfreq
> * MinShouldMatchScorer returns how many of its subscorers are matching
> * {Exact|Sloppy}PhraseScorer returns how many phrases it has found on a document
> In addition, freq() is never actually called on TermScorer, and it's only used in explain() on the phrase scorers.
> We should make Scorer extend DocIdSetIterator instead.  In place of freq(), Scorer would have a coord() method that by default returns 1, and for boolean scorers returns how many subscorers are matching.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org