You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "fdcavalcanti (via GitHub)" <gi...@apache.org> on 2025/02/10 16:46:57 UTC
[PR] boards/xtensa: unify WiFi source code for ESP32|S2|S3 (2/2) [nuttx]
fdcavalcanti opened a new pull request, #15805:
URL: https://github.com/apache/nuttx/pull/15805
## Summary
This PR modifies ESP32 and ESP32S3 boards to use new symbols for wireless connectivity.
It is a complementary part of this #15804.
## Impact
KConfig prefixes related to radio functionalities have been modified. ESP32_* and ESP32S3_* are replaced with ESPRESSIF_* (CONFIG_ESP32_WIFI -> CONFIG_ESPRESSIF_WIFI). This is applied through arch/ and also board/ (different PR) and may impact users if they are running custom defconfigs.
BLE symbols are altered as well, since they share some common wireless implementations. However, source code for BLE has not been merged into the common layer.
## Testing
Reduces the amount of source code required for WiFi support.
No difference in performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] boards/xtensa: unify WiFi source code for ESP32|S2|S3 (2/2) [nuttx]
Posted by "fdcavalcanti (via GitHub)" <gi...@apache.org>.
fdcavalcanti closed pull request #15805: boards/xtensa: unify WiFi source code for ESP32|S2|S3 (2/2)
URL: https://github.com/apache/nuttx/pull/15805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] boards/xtensa: unify WiFi source code for ESP32|S2|S3 (2/2) [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #15805:
URL: https://github.com/apache/nuttx/pull/15805#issuecomment-2649122375
@fdcavalcanti what was the issue in the PR? I saw that @tmedicci converted it to draft
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] boards/xtensa: unify WiFi source code for ESP32|S2|S3 (2/2) [nuttx]
Posted by "fdcavalcanti (via GitHub)" <gi...@apache.org>.
fdcavalcanti commented on PR #15805:
URL: https://github.com/apache/nuttx/pull/15805#issuecomment-2649438921
I broke it up in a arch PR and a board PR. It should be each PR for a SoC instead.
Will send it again soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] boards/xtensa: unify WiFi source code for ESP32|S2|S3 (2/2) [nuttx]
Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #15805:
URL: https://github.com/apache/nuttx/pull/15805#issuecomment-2648685694
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
The PR seems to mostly meet the NuttX requirements, but is missing some key information in the Testing section.
Here's a breakdown:
**Strengths:**
* **Summary:** Clearly explains the "why," "what," and "how" of the change. The reference to #15804 provides valuable context.
* **Impact:** Addresses all the required impact areas. The description of the impact on users who use custom defconfigs is particularly helpful. The explanation of the BLE symbol changes, even though the code hasn't been merged, demonstrates good foresight.
**Weaknesses:**
* **Testing:** While it mentions the *results* of the testing (reduced code size, no performance difference), it lacks crucial details about the testing *process* itself. The required "Build Host(s)" and "Target(s)" information is missing. Critically, the "Testing logs before change" and "Testing logs after change" sections are empty. This makes it impossible to verify the claims made about code size reduction and performance.
**To make this PR fully compliant:**
1. **Testing - Build Host(s):** Specify the operating system, CPU architecture, and compiler version used for building the code. Example: `Linux, x86_64, GCC 12.2.0`
2. **Testing - Target(s):** Specify the target architecture, board, and configuration used for testing. Example: `sim:qemu-x86_64, esp32:esp32-devkitc`
3. **Testing Logs:** Provide actual logs demonstrating the functionality before and after the change. This could include output from `make`, boot logs from the target, or output from a test application that exercises the Wi-Fi functionality. Even if the logs are lengthy, include a representative snippet or link to a separate log file. If no functional difference is expected in the logs, explain that clearly and perhaps provide some other form of evidence (e.g., code size comparison).
By adding this missing information, the PR will be much stronger and easier to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org