[jira] [Commented] (JCRVLT-560) Clarify binary properties in FileVault DocView

["Konrad Windszus (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCRVLT-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417311#comment-17417311 ] 

Konrad Windszus commented on JCRVLT-560:
----------------------------------------

[~tripod] Is FileVault DocView not supposed to support binary properties except via binary references? This is IMHO problematic as I always thought that even JCR 2.0 compliant DocViews would be supported during package import as well... At least http://jackrabbit.apache.org/filevault/vaultfs.html#Deserialization does not state explicitly that only FileVault DocView is supported...

> Clarify binary properties in FileVault DocView
> ----------------------------------------------
>
>                 Key: JCRVLT-560
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-560
>             Project: Jackrabbit FileVault
>          Issue Type: Bug
>            Reporter: Konrad Windszus
>            Priority: Major
>             Fix For: 3.5.4
>
>
> In contrast to JCR 2.0 DocView which states
> bq. If P is a BINARY property its value is Base64 encoded. The resulting string becomes the value of the XML attribute P.
> (https://docs.adobe.com/content/docs/en/spec/jcr/2.0/7_Export.html#7.3%20Document%20View) the binary support in FileVault DocView uses the default conversion from String to UTF-8 byte array encoding for multi-value properties in https://github.com/apache/jackrabbit-filevault/blob/b8627b9548ff1335cc0e497797b701a02a966654/vault-core/src/main/java/org/apache/jackrabbit/vault/util/DocViewProperty.java#L500  (https://docs.adobe.com/content/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.6.4.1%20From%20STRING%20To) or only binary references for single values: https://github.com/apache/jackrabbit-filevault/blob/b8627b9548ff1335cc0e497797b701a02a966654/vault-core/src/main/java/org/apache/jackrabbit/vault/util/DocViewProperty.java#L519.
> This difference is currently not explained in https://jackrabbit.apache.org/filevault/docview.html and the handling is inconsistent between single- and multi-value.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)