You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "dentiny (via GitHub)" <gi...@apache.org> on 2026/03/24 09:24:32 UTC

[PR] fix(tracing): fix trace span instrumentation [opendal]

dentiny opened a new pull request, #7292:
URL: https://github.com/apache/opendal/pull/7292

   # Which issue does this PR close?
   
   Closes https://github.com/apache/opendal/issues/7291
   
   # Rationale for this change
   
   - enter call sets the current span as thread-local variable, with task to execute yields, another task could be scheduled to the current thread and mistakenly use this thread-local span, leading to incorrect traces
   - when the current task gets re-scheduled, it could be scheduled to another thread with the span destructed in another thread....
   
   # What changes are included in this PR?
   
   Follow the documentation (https://github.com/apache/opendal/issues/7291) to use `instrument` instead of `enter` to annotate tasks to await.
   
   # Are there any user-facing changes?
   
   No
   
   # AI Usage Statement
   
   No AI involvement.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(tracing): fix trace span instrumentation [opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #7292:
URL: https://github.com/apache/opendal/pull/7292


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org