You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "PHILO-HE (via GitHub)" <gi...@apache.org> on 2025/09/17 08:55:35 UTC
Re: [PR] [GLUTEN-10629][FLINK] Support udf count_char [incubator-gluten]
PHILO-HE commented on code in PR #10674:
URL: https://github.com/apache/incubator-gluten/pull/10674#discussion_r2354800288
##########
gluten-flink/planner/src/main/java/org/apache/gluten/rexnode/functions/RexCallConverterFactory.java:
##########
@@ -99,7 +99,9 @@ public class RexCallConverterFactory {
Map.entry("IS NOT NULL", Arrays.asList(() -> new DefaultRexCallConverter("is_not_null"))),
Map.entry(
"REGEXP_EXTRACT", Arrays.asList(() -> new DefaultRexCallConverter("regexp_extract"))),
- Map.entry("LOWER", Arrays.asList(() -> new DefaultRexCallConverter("lower"))));
+ Map.entry("LOWER", Arrays.asList(() -> new DefaultRexCallConverter("lower"))),
+ Map.entry("count_char", Arrays.asList(() -> new DefaultRexCallConverter("count_char"))),
Review Comment:
Do we have a convention that capitalizes the function name as the key like others? i.e., `Map.entry("COUNT_CHAR" `. Though I guess it is case insensitive.
##########
gluten-flink/planner/src/main/java/org/apache/gluten/rexnode/functions/RexCallConverterFactory.java:
##########
@@ -99,7 +99,9 @@ public class RexCallConverterFactory {
Map.entry("IS NOT NULL", Arrays.asList(() -> new DefaultRexCallConverter("is_not_null"))),
Map.entry(
"REGEXP_EXTRACT", Arrays.asList(() -> new DefaultRexCallConverter("regexp_extract"))),
- Map.entry("LOWER", Arrays.asList(() -> new DefaultRexCallConverter("lower"))));
+ Map.entry("LOWER", Arrays.asList(() -> new DefaultRexCallConverter("lower"))),
+ Map.entry("count_char", Arrays.asList(() -> new DefaultRexCallConverter("count_char"))),
Review Comment:
Has Velox already supported this function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org