Change in asterixdb[master]: [ASTERIXDB-2148][FUN] Add init parameter for external UDF

["Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>]

Till Westmann has posted comments on this change.

Change subject: [ASTERIXDB-2148][FUN] Add init parameter for external UDF
......................................................................


Patch Set 24:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2107/24/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java:

PS24, Line 228: getExternalFunctionFullName(libraryName, function.getName().trim()
This is exactly the definition of functionFullName in l.218.
Let's use that.


https://asterix-gerrit.ics.uci.edu/#/c/2107/24/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/RuntimeExternalFunctionUtil.java
File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/RuntimeExternalFunctionUtil.java:

PS24, Line 37: RuntimeExternalFunctionUtil
I think that this class is unused. Could you validate (and remove if so)?


https://asterix-gerrit.ics.uci.edu/#/c/2107/24/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/KeywordsDetectorFunction.java
File asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/KeywordsDetectorFunction.java:

PS24, Line 55: functionParameters
Check the length of the list to provide a better error message if it's too short?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2107
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I567ce0bcac288267595b2565e53fea61e16fbd65
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang <xk...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Xikui Wang <xk...@gmail.com>
Gerrit-HasComments: Yes