You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Murat Sutunc <mu...@microsoft.com> on 2015/05/27 18:40:33 UTC
Couple questions
Hey everyone,
I've two simple questions:
1) How do we close github issues? There are PRs that are older than a year and there's no need for having them around. In fact having them around for so long can be discouraging to new contributors.
2) If we want to add pictures to plugin documentation, where should we store the pictures? Currently the English doc lives under plugin\README.md, translations live under plugin\doc\language\index.md. Should I go ahead and create an images folder under docs or will it break some automation we have?
Sorry for the noise :)
Thanks,
Murat
Re: Couple questions
Posted by Shazron <sh...@gmail.com>.
1) We can't directly. Some have resorted to updating some doc (maybe
we need a dummy doc) and add the text (closes #XX) where XX is the PR
number.
2) Not sure about the breakage part. But I would put it under docs for sure.
On Wed, May 27, 2015 at 9:40 AM, Murat Sutunc <mu...@microsoft.com> wrote:
> Hey everyone,
> I've two simple questions:
>
> 1) How do we close github issues? There are PRs that are older than a year and there's no need for having them around. In fact having them around for so long can be discouraging to new contributors.
>
> 2) If we want to add pictures to plugin documentation, where should we store the pictures? Currently the English doc lives under plugin\README.md, translations live under plugin\doc\language\index.md. Should I go ahead and create an images folder under docs or will it break some automation we have?
>
> Sorry for the noise :)
>
> Thanks,
> Murat
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: Couple questions
Posted by Steven Gill <st...@gmail.com>.
[1]
https://github.com/apache/cordova-coho/blob/e32609eca599021f535126a5e18995706b7f7741/docs/processing-pull-requests.md#stale-pull-requests
[2] images subdirectory in docs should be fine
On Wed, May 27, 2015 at 10:18 AM, Victor Sosa <so...@gmail.com>
wrote:
> Hello Murat.
> I can speak on Translation side. No, adding changing images won't break the
> translated documents. In fact, in translation process, we take the text
> blocks only, not multimedia, HTML format or whatsoever. Lisa can correct me
> though.
>
> On Wed, May 27, 2015 at 11:40 AM Murat Sutunc <mu...@microsoft.com>
> wrote:
>
> > Hey everyone,
> > I've two simple questions:
> >
> > 1) How do we close github issues? There are PRs that are older than
> a
> > year and there's no need for having them around. In fact having them
> around
> > for so long can be discouraging to new contributors.
> >
> > 2) If we want to add pictures to plugin documentation, where should
> > we store the pictures? Currently the English doc lives under
> > plugin\README.md, translations live under plugin\doc\language\index.md.
> > Should I go ahead and create an images folder under docs or will it break
> > some automation we have?
> >
> > Sorry for the noise :)
> >
> > Thanks,
> > Murat
> >
>
Re: Couple questions
Posted by Victor Sosa <so...@gmail.com>.
Hello Murat.
I can speak on Translation side. No, adding changing images won't break the
translated documents. In fact, in translation process, we take the text
blocks only, not multimedia, HTML format or whatsoever. Lisa can correct me
though.
On Wed, May 27, 2015 at 11:40 AM Murat Sutunc <mu...@microsoft.com> wrote:
> Hey everyone,
> I've two simple questions:
>
> 1) How do we close github issues? There are PRs that are older than a
> year and there's no need for having them around. In fact having them around
> for so long can be discouraging to new contributors.
>
> 2) If we want to add pictures to plugin documentation, where should
> we store the pictures? Currently the English doc lives under
> plugin\README.md, translations live under plugin\doc\language\index.md.
> Should I go ahead and create an images folder under docs or will it break
> some automation we have?
>
> Sorry for the noise :)
>
> Thanks,
> Murat
>