You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "westonpace (via GitHub)" <gi...@apache.org> on 2023/04/14 19:24:20 UTC
[GitHub] [arrow] westonpace opened a new pull request, #35145: GH-35144: [C++] Fix a unit test broken when the output order of the aggregate node changed
westonpace opened a new pull request, #35145:
URL: https://github.com/apache/arrow/pull/35145
### Rationale for this change
The unit test was broken by a recent change and needed to be updated.
### What changes are included in this PR?
The unit test has been updated to expect the correct order.
### Are these changes tested?
Yes
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35145: GH-35144: [C++] Fix a unit test broken when the output order of the aggregate node changed
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35145:
URL: https://github.com/apache/arrow/pull/35145#issuecomment-1509117321
:warning: GitHub issue #35144 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #35145: GH-35144: [C++] Fix a unit test broken when the output order of the aggregate node changed
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on PR #35145:
URL: https://github.com/apache/arrow/pull/35145#issuecomment-1509185673
> I thought all tests passed before I merged it but I must have missed somehow.
They probably did all pass but they ran before #34904 was merged in. This kind of thing happens every so often when two PRs conflict with each other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] icexelloss commented on pull request #35145: GH-35144: [C++] Fix a unit test broken when the output order of the aggregate node changed
Posted by "icexelloss (via GitHub)" <gi...@apache.org>.
icexelloss commented on PR #35145:
URL: https://github.com/apache/arrow/pull/35145#issuecomment-1509148086
Thanks @westonpace - I found the same issue. I thought all tests passed before I merged it but I must have missed somehow. Thanks for fixing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35145: GH-35144: [C++] Fix a unit test broken when the output order of the aggregate node changed
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35145:
URL: https://github.com/apache/arrow/pull/35145#issuecomment-1509117287
* Closes: #35144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35145: GH-35144: [C++] Fix a unit test broken when the output order of the aggregate node changed
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35145:
URL: https://github.com/apache/arrow/pull/35145#issuecomment-1511173356
Benchmark runs are scheduled for baseline = 2ba66285c6c78b43acdccf114fcb61aad090fb93 and contender = d4f73322a093c053c60ec0eee2a7bd08f335f7f0. d4f73322a093c053c60ec0eee2a7bd08f335f7f0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/18752de41d9245979d9e7a48d12734aa...b2ac32d1046a4109b10da880c9e888ef/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/7042114aa486472891eb16b294ad9521...f55fa939d21c44659d2990d55fa982cc/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9fd7be9529d647c4a45ae452b34baeab...10e11e6d22fb4950beb800383a1acc20/)
[Finished :arrow_down:0.34% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/1c056d3b095e492e971c7798a805d7ee...ab68c2006d894c18b2b5767ef8113b18/)
Buildkite builds:
[Finished] [`d4f73322` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2719)
[Failed] [`d4f73322` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2753)
[Finished] [`d4f73322` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2717)
[Finished] [`d4f73322` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2744)
[Finished] [`2ba66285` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2718)
[Failed] [`2ba66285` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2752)
[Finished] [`2ba66285` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2716)
[Finished] [`2ba66285` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2743)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace merged pull request #35145: GH-35144: [C++] Fix a unit test broken when the output order of the aggregate node changed
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace merged PR #35145:
URL: https://github.com/apache/arrow/pull/35145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org