[jira] [Commented] (PROTON-336) pn_messenger_put does not clear PN_OVERFLOW error after expanding its buffer

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PROTON-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13746122#comment-13746122 ] 

ASF subversion and git services commented on PROTON-336:
--------------------------------------------------------

Commit 1516184 from rhs@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1516184 ]

don't set an error for PN_OVERFLOW, this fixes PROTON-336, also fixed error accessors to be consistent
                
> pn_messenger_put does not clear PN_OVERFLOW error after expanding its buffer
> ----------------------------------------------------------------------------
>
>                 Key: PROTON-336
>                 URL: https://issues.apache.org/jira/browse/PROTON-336
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: 0.3
>            Reporter: Rob Percival
>
> In pn_messenger_put, the buffer is initialised to an array of 1024 bytes. It then tries to encode the message and if it won't fit, a PN_OVERFLOW error occurs (against the message). The buffer is then doubled in size and it retries encoding. However, the PN_OVERFLOW error is not cleared. This means that after pn_messenger_put returns successfully, calling pn_message_errno will report that a PN_OVERFLOW error occurred. The error message, unhelpfully, is "data error: (null)".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira