[GitHub] [hadoop] ferdelyi commented on pull request #5638: HADOOP-18709. Add curator based ZooKeeper communication support over…

["ferdelyi (via GitHub)" <gi...@apache.org>]

ferdelyi commented on PR #5638:
URL: https://github.com/apache/hadoop/pull/5638#issuecomment-1548089533

   Thank you Szilard for the CR.
   
   The change was exclusively tested with the unit test, which is a kind of integration test, as a ZK Server was brought up and the communication tested between the client and the server.
   
   This code change is in the common code base and there is no component calling it yet. Once YARN-11468 [Zookeeper SSL/TLS support] is implemented, we can test it in a real cluster environment.
   
   Wondering if we should update the https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs-rbf/dependency-analysis.html page with the Netty dependency? The parameter descriptions are added to the commit to the core-default.xml.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org