You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/18 14:00:13 UTC
[GitHub] [arrow] raulcd opened a new pull request, #13188: ARROW-16317: [CI][Dev] Do not use incremental ids on crossbow submit action branches
raulcd opened a new pull request, #13188:
URL: https://github.com/apache/arrow/pull/13188
The aim of this PR is to avoid a possible race condition when submitting crossbow builds. Currently when there is a race condition when submitting crossbow builds we can see the following type of error:
```
Failed to push updated references, potentially because of credential issues: ['refs/heads/actions-1883-github-wheel-windows-cp310-amd64', 'refs/tags/actions-1883-github-wheel-windows-cp310-amd64', 'refs/heads/actions-1883-github-wheel-windows-cp39-amd64', 'refs/tags/actions-1883-github-wheel-windows-cp39-amd64', 'refs/heads/actions-1883-github-wheel-windows-cp37-amd64', 'refs/tags/actions-1883-github-wheel-windows-cp37-amd64', 'refs/heads/actions-1883-github-wheel-windows-cp38-amd64', 'refs/tags/actions-1883-github-wheel-windows-cp38-amd64', 'refs/heads/actions-1883']
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/2195038965
```
The idea is to use a 10 characters hex from an uuid instead of an incremental id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13188: ARROW-16317: [CI][Dev] Do not use incremental ids on crossbow submit action branches
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13188:
URL: https://github.com/apache/arrow/pull/13188#issuecomment-1130394654
Revision: ba2bd968ce4ce03474f4195dcf79dab5ed3e6cad
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2114](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2114)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-2114-github-example-cpp-minimal-build-static)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #13188: ARROW-16317: [CI][Dev] Do not use incremental ids on crossbow submit action branches
Posted by GitBox <gi...@apache.org>.
raulcd commented on PR #13188:
URL: https://github.com/apache/arrow/pull/13188#issuecomment-1130230357
@github-actions crossbow submit example-cpp-minimal-build-static
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #13188: ARROW-16317: [CI][Dev] Do not use incremental ids on crossbow submit action branches
Posted by GitBox <gi...@apache.org>.
raulcd commented on PR #13188:
URL: https://github.com/apache/arrow/pull/13188#issuecomment-1130390749
@github-actions crossbow submit example-cpp-minimal-build-static
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #13188: ARROW-16317: [CI][Dev] Do not use incremental ids on crossbow submit action branches
Posted by GitBox <gi...@apache.org>.
raulcd commented on PR #13188:
URL: https://github.com/apache/arrow/pull/13188#issuecomment-1130416133
ok, I have been doing some investigation and the bot comment workflow is checking out from master so it is not really picking up my changes on this PR:
```
/usr/bin/git checkout --progress --force -B master refs/remotes/origin/master
Reset branch 'master'
branch 'master' set up to track 'origin/master'.
```
@kszucs have you worked around that in the past? do you know if there is a way I could test this workflow change from my PR branch?
Otherwise I'll keep investigating tomorrow I might try to tweak a forked repo to trigger a comment bot and archery
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #13188: ARROW-16317: [CI][Dev] Do not use incremental ids on crossbow submit action branches
Posted by GitBox <gi...@apache.org>.
raulcd commented on PR #13188:
URL: https://github.com/apache/arrow/pull/13188#issuecomment-1131630737
Hi @kszucs I have removed the second commit that allowed us to test the comment bot changes checking out archery from the PR as discussed. The good thing is I know how I can test it in the future and we have been able to verify the change is successful from my fork tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13188: ARROW-16317: [CI][Dev] Do not use incremental ids on crossbow submit action branches
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13188:
URL: https://github.com/apache/arrow/pull/13188#issuecomment-1130365008
Revision: 14e61415721a066c2baee1161d713c265a3c63cc
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2113](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2113)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-2113-github-example-cpp-minimal-build-static)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13188: ARROW-16317: [CI][Dev] Do not use incremental ids on crossbow submit action branches
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13188:
URL: https://github.com/apache/arrow/pull/13188#issuecomment-1130407476
Revision: 2bdeb667124c677be176e4e9b2fb3701f6f02b01
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2115](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2115)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-2115-github-example-cpp-minimal-build-static)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13188: ARROW-16317: [CI][Dev] Do not use incremental ids on crossbow submit action branches
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13188:
URL: https://github.com/apache/arrow/pull/13188#issuecomment-1130102010
Revision: b47f16a5aa61b40a6d5699a71787807e8fff8aa0
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2111](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2111)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-2111-github-example-cpp-minimal-build-static)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #13188: ARROW-16317: [CI][Dev] Do not use incremental ids on crossbow submit action branches
Posted by GitBox <gi...@apache.org>.
kszucs commented on PR #13188:
URL: https://github.com/apache/arrow/pull/13188#issuecomment-1130208550
> It does not seem to be working yet, that's why I've marked it as draft again, I am investigating why the branch from the triggered action hasn't been created with the new naming convention.
Thanks for working on this! Let me know when it's ready for review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #13188: ARROW-16317: [CI][Dev] Do not use incremental ids on crossbow submit action branches
Posted by GitBox <gi...@apache.org>.
raulcd commented on PR #13188:
URL: https://github.com/apache/arrow/pull/13188#issuecomment-1130141747
It does not seem to be working yet, that's why I've marked it as draft again, I am investigating why the branch from the triggered action hasn't been created with the new naming convention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #13188: ARROW-16317: [CI][Dev] Do not use incremental ids on crossbow submit action branches
Posted by GitBox <gi...@apache.org>.
kszucs commented on PR #13188:
URL: https://github.com/apache/arrow/pull/13188#issuecomment-1131798137
@raulcd we may want to set the hash based job id as default so we wouldn't need to fetch the references from crossbow at all. I regularly use `archery crossbow submit --no-fetch ...` because libgit2 isn't great with fetching.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #13188: ARROW-16317: [CI][Dev] Do not use incremental ids on crossbow submit action branches
Posted by GitBox <gi...@apache.org>.
raulcd commented on PR #13188:
URL: https://github.com/apache/arrow/pull/13188#issuecomment-1130419772
This is the URL for the triggered action for the comment bot where the usage of the master branch can be seen: https://github.com/apache/arrow/runs/6495575450?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #13188: ARROW-16317: [CI][Dev] Do not use incremental ids on crossbow submit action branches
Posted by GitBox <gi...@apache.org>.
raulcd commented on PR #13188:
URL: https://github.com/apache/arrow/pull/13188#issuecomment-1130405377
@github-actions crossbow submit example-cpp-minimal-build-static
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13188: ARROW-16317: [CI][Dev] Do not use incremental ids on crossbow submit action branches
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13188:
URL: https://github.com/apache/arrow/pull/13188#issuecomment-1130086762
https://issues.apache.org/jira/browse/ARROW-16317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #13188: ARROW-16317: [CI][Dev] Do not use incremental ids on crossbow submit action branches
Posted by GitBox <gi...@apache.org>.
raulcd commented on PR #13188:
URL: https://github.com/apache/arrow/pull/13188#issuecomment-1131530252
@github-actions crossbow submit example-cpp-minimal-build-static
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13188: ARROW-16317: [CI][Dev] Do not use incremental ids on crossbow submit action branches
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13188:
URL: https://github.com/apache/arrow/pull/13188#issuecomment-1131536647
Revision: 6a2ab6286d1ac7eef1d51b31649d961faa224c14
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2118](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2118)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-2118-github-example-cpp-minimal-build-static)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #13188: ARROW-16317: [CI][Dev] Do not use incremental ids on crossbow submit action branches
Posted by GitBox <gi...@apache.org>.
raulcd commented on PR #13188:
URL: https://github.com/apache/arrow/pull/13188#issuecomment-1131556113
Hi @kszucs, I think this is ready for review, it has been slightly tricky to validate so I am going to explain on the comment here.
There are two commits on this PR, one with the change of using the 10 digit hex as part of the action branch name and one to modify the comment bot in order to pick the PR changes on archery instead of always from master. This second commit will allow us to be able to test changes for the comment bot from the PR.
I have tested on my [own fork ](https://github.com/raulcd/arrow) by:
* Merging to my master branch [the commit about the comment bot](https://github.com/raulcd/arrow/commit/0ab58a57708484ab40ca524cf62a2159e2ff3954) so it is able to checkout the PR instead of master as seen on [the comment bot action triggered](https://github.com/raulcd/arrow/runs/6505894312?check_suite_focus=true)
* Creating a [PR with the changes on the crossbow submit action](https://github.com/raulcd/arrow/pull/2) on my own repo and validate the [branch created on crossbow](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-364c9d4277-github-example-cpp-minimal-build-static) is the correct one
Please let me know your thoughts and if you would like me to split the two commits on two different issues as they are solving slightly different issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs closed pull request #13188: ARROW-16317: [CI][Dev] Do not use incremental ids on crossbow submit action branches
Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #13188: ARROW-16317: [CI][Dev] Do not use incremental ids on crossbow submit action branches
URL: https://github.com/apache/arrow/pull/13188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #13188: ARROW-16317: [CI][Dev] Do not use incremental ids on crossbow submit action branches
Posted by GitBox <gi...@apache.org>.
raulcd commented on PR #13188:
URL: https://github.com/apache/arrow/pull/13188#issuecomment-1130074806
@github-actions crossbow submit example-cpp-minimal-build-static
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13188: ARROW-16317: [CI][Dev] Do not use incremental ids on crossbow submit action branches
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13188:
URL: https://github.com/apache/arrow/pull/13188#issuecomment-1131532814
Revision: 0ed864177e83ce21ca63cea8f69d65baa9d4eebc
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2117](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2117)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-2117-github-example-cpp-minimal-build-static)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #13188: ARROW-16317: [CI][Dev] Do not use incremental ids on crossbow submit action branches
Posted by GitBox <gi...@apache.org>.
raulcd commented on PR #13188:
URL: https://github.com/apache/arrow/pull/13188#issuecomment-1131534621
@github-actions crossbow submit example-cpp-minimal-build-static
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13188: ARROW-16317: [CI][Dev] Do not use incremental ids on crossbow submit action branches
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13188:
URL: https://github.com/apache/arrow/pull/13188#issuecomment-1132531534
Benchmark runs are scheduled for baseline = 7f31c9d2d95b5b30fa7997c2519d3b85919f1fd9 and contender = f1363657ab61ee95fe1c71d2952f436f1d49ffc8. f1363657ab61ee95fe1c71d2952f436f1d49ffc8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/3586128d4a81497f948a32cdb33e0779...600d8dc636a449068df00d5955cf280b/)
[Failed :arrow_down:0.66% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2d82cc41db6c40f3b129031f450682e6...6a0232da6810417cb203f513e3038369/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/45f5916ecab84f24a93e9797381ead0d...f359287b1fd641d2b937d89d94490d7e/)
[Finished :arrow_down:0.32% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a1198243dc4b4b49aeacf52faa380fa6...1182f0cba9d64e0783379a4dbd3eac7c/)
Buildkite builds:
[Finished] [`f1363657` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/799)
[Failed] [`f1363657` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/796)
[Failed] [`f1363657` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/786)
[Finished] [`f1363657` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/802)
[Finished] [`7f31c9d2` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/798)
[Failed] [`7f31c9d2` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/795)
[Failed] [`7f31c9d2` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/785)
[Finished] [`7f31c9d2` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/801)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org