[jira] [Commented] (AURORA-1820) Reduce storage write lock contention by adopting Double-Checked Locking pattern in TimedOutTaskHandler

["Zameer Manji (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AURORA-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15667969#comment-15667969 ] 

Zameer Manji commented on AURORA-1820:
--------------------------------------

Good find [~mnurolahzade]!

Do we measure throughput of {{TimedOutTaskHandler}} in benchmarks already?

> Reduce storage write lock contention by adopting Double-Checked Locking pattern in TimedOutTaskHandler
> ------------------------------------------------------------------------------------------------------
>
>                 Key: AURORA-1820
>                 URL: https://issues.apache.org/jira/browse/AURORA-1820
>             Project: Aurora
>          Issue Type: Task
>          Components: Efficiency, Scheduler
>            Reporter: Mehrdad Nurolahzade
>            Assignee: Mehrdad Nurolahzade
>            Priority: Critical
>
> {{TimedOutTaskHandler}} acquires storage write lock for every task every time they transition to a transient state. It then verifies after a default time-out period of 5 minutes if the task has transitioned out of the transient state. 
> The verification step takes place while holding the storage write lock. In over 99% of cases the logic short-circuits and returns from {{StateManagerImpl.updateTaskAndExternalState()}} once it learns task has transitioned out of the transient state.
> Reduce storage write lock contention by adopting [Double-Checked Locking|https://en.wikipedia.org/wiki/Double-checked_locking] pattern in {{TimedOutTaskHandler.run()}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)