You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by st...@apache.org on 2014/12/23 10:42:12 UTC
svn commit: r1647518 - in
/subversion/branches/fsx-id/subversion/libsvn_fs_x: caching.c fs.h
Author: stefan2
Date: Tue Dec 23 09:42:12 2014
New Revision: 1647518
URL: http://svn.apache.org/r1647518
Log:
On the fsx-id branch: Remove the unused revision root ID cache.
This is a remnant of FSFS pre-format 7.
* subversion/libsvn_fs_x/fs.h
(fs_x_data_t): Remove the cache instance.
* subversion/libsvn_fs_x/caching.c
(svn_fs_x__initialize_caches): One less to initialize.
Modified:
subversion/branches/fsx-id/subversion/libsvn_fs_x/caching.c
subversion/branches/fsx-id/subversion/libsvn_fs_x/fs.h
Modified: subversion/branches/fsx-id/subversion/libsvn_fs_x/caching.c
URL: http://svn.apache.org/viewvc/subversion/branches/fsx-id/subversion/libsvn_fs_x/caching.c?rev=1647518&r1=1647517&r2=1647518&view=diff
==============================================================================
--- subversion/branches/fsx-id/subversion/libsvn_fs_x/caching.c (original)
+++ subversion/branches/fsx-id/subversion/libsvn_fs_x/caching.c Tue Dec 23 09:42:12 2014
@@ -405,27 +405,6 @@ svn_fs_x__initialize_caches(svn_fs_t *fs
apr_pool_cleanup_null);
#endif
- /* Make the cache for revision roots. For the vast majority of
- * commands, this is only going to contain a few entries (svnadmin
- * dump/verify is an exception here), so to reduce overhead let's
- * try to keep it to just one page. I estimate each entry has about
- * 72 bytes of overhead (svn_revnum_t key, svn_fs_id_t +
- * id_private_t + 3 strings for value, and the cache_entry); the
- * default pool size is 8192, so about a hundred should fit
- * comfortably. */
- SVN_ERR(create_cache(&(ffd->rev_root_id_cache),
- NULL,
- membuffer,
- 1, 100,
- svn_fs_x__serialize_id,
- svn_fs_x__deserialize_id,
- sizeof(svn_revnum_t),
- apr_pstrcat(pool, prefix, "RRI", SVN_VA_NULL),
- 0,
- fs,
- no_handler,
- fs->pool, pool));
-
/* Rough estimate: revision DAG nodes have size around 320 bytes, so
* let's put 16 on a page. */
SVN_ERR(create_cache(&(ffd->rev_node_cache),
Modified: subversion/branches/fsx-id/subversion/libsvn_fs_x/fs.h
URL: http://svn.apache.org/viewvc/subversion/branches/fsx-id/subversion/libsvn_fs_x/fs.h?rev=1647518&r1=1647517&r2=1647518&view=diff
==============================================================================
--- subversion/branches/fsx-id/subversion/libsvn_fs_x/fs.h (original)
+++ subversion/branches/fsx-id/subversion/libsvn_fs_x/fs.h Tue Dec 23 09:42:12 2014
@@ -279,10 +279,6 @@ typedef struct fs_x_data_t
e.g. memcached may be ignored as caching is an optional feature. */
svn_boolean_t fail_stop;
- /* A cache of revision root IDs, mapping from (svn_revnum_t *) to
- (svn_fs_id_t *). (Not threadsafe.) */
- svn_cache__t *rev_root_id_cache;
-
/* Caches native dag_node_t* instances and acts as a 1st level cache */
fs_x_dag_cache_t *dag_node_cache;