[jira] [Work logged] (HIVE-22585) Clean up catalog/db/table name usage

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-22585?focusedWorklogId=389930&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389930 ]

ASF GitHub Bot logged work on HIVE-22585:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Feb/20 13:32
            Start Date: 20/Feb/20 13:32
    Worklog Time Spent: 10m 
      Work Description: kgyrtkirk commented on pull request #876: HIVE-22585: Clean up catalog/db/table name usage
URL: https://github.com/apache/hive/pull/876#discussion_r381992821
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/cache/results/QueryResultsCache.java
 ##########
 @@ -631,13 +632,13 @@ public long getSize() {
     }
   }
 
-  public void notifyTableChanged(String dbName, String tableName, long updateTime) {
-    LOG.debug("Table changed: {}.{}, at {}", dbName, tableName, updateTime);
+  public void notifyTableChanged(TableName tableName, long updateTime) {
+    LOG.debug("Table changed: {}, at {}", tableName.getNotEmptyDbTable(), updateTime);
     // Invalidate all cache entries using this table.
     List<CacheEntry> entriesToInvalidate = null;
     rwLock.writeLock().lock();
     try {
-      String key = (dbName.toLowerCase() + "." + tableName.toLowerCase());
+      String key = (tableName.getNotEmptyDbTable().toLowerCase());
 
 Review comment:
   we might want to consider to remove all these "toLowerCase"  calls;and instead make it a contract for tablenames; so it's enforced at the time the tablename is created
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 389930)
    Time Spent: 20m  (was: 10m)

> Clean up catalog/db/table name usage
> ------------------------------------
>
>                 Key: HIVE-22585
>                 URL: https://issues.apache.org/jira/browse/HIVE-22585
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: David Lavati
>            Assignee: David Lavati
>            Priority: Major
>              Labels: pull-request-available, refactor
>         Attachments: HIVE-22585.01.patch, HIVE-22585.02.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> This is a followup to HIVE-21198 to address some additional improvement ideas for the TableName object mentioned in [https://github.com/apache/hive/pull/550] and attempt to remove all the fishy usages of db/tablenames, as a number of places still rely on certain state changes/black magic.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)