You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/10/20 19:22:52 UTC

[GitHub] [superset] craig-rueda commented on a change in pull request #17174: fix: use typing_extension instead

craig-rueda commented on a change in pull request #17174:
URL: https://github.com/apache/superset/pull/17174#discussion_r733079177



##########
File path: superset/config.py
##########
@@ -30,24 +30,15 @@
 import sys
 from collections import OrderedDict
 from datetime import date, timedelta
-from typing import (
-    Any,
-    Callable,
-    Dict,
-    List,
-    Literal,
-    Optional,
-    Type,
-    TYPE_CHECKING,
-    Union,
-)
+from typing import Any, Callable, Dict, List, Optional, Type, TYPE_CHECKING, Union

Review comment:
       Is this compatible with `3.8` AND `3.7`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org