You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/09/24 05:20:20 UTC
[GitHub] [flink] XComp commented on a change in pull request #13454: [FLINK-19304][coordination] Add FLIP-138 feature toggle
XComp commented on a change in pull request #13454:
URL: https://github.com/apache/flink/pull/13454#discussion_r494044125
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/ClusterOptions.java
##########
@@ -92,4 +92,15 @@
"to a JVM deadlock. See %s for details.",
link("https://issues.apache.org/jira/browse/FLINK-16510", "FLINK-16510"))
.build());
+
+ @Documentation.ExcludeFromDocumentation
+ public static final ConfigOption<Boolean> ENABLE_DECLARATIVE_RESOURCE_MANAGEMENT = ConfigOptions
+ .key("cluster.declarative-resource-management.enabled")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("Defines whether the cluster uses declarative resource management.");
+
+ public static boolean isDeclarativeResourceManagementEnabled(Configuration configuration) {
+ return configuration.get(ENABLE_DECLARATIVE_RESOURCE_MANAGEMENT) || System.getProperties().containsKey("flink.tests.enable-declarative");
Review comment:
What’s the reason for us introducing a system property besides the configuration property? Is this to support easier e2e testing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org