You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/11/14 08:04:00 UTC
[jira] [Commented] (CB-13569) The LocalFileSystem enum in the
typescript file is inverted
[ https://issues.apache.org/jira/browse/CB-13569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251050#comment-16251050 ]
ASF GitHub Bot commented on CB-13569:
-------------------------------------
antondb opened a new pull request #224: CB-13569
URL: https://github.com/apache/cordova-plugin-file/pull/224
…STENT were swapped.
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
This bug affects anyone using the typescript type file.
### What does this PR do?
Changes the localfilesystem enum so that it reflects the values in the code.
### What testing has been done on this change?
Loaded the type file in VSCode and tested a phone build on Android and IOS.
### Checklist
- [x ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [x ] Added automated test coverage as appropriate for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> The LocalFileSystem enum in the typescript file is inverted
> -----------------------------------------------------------
>
> Key: CB-13569
> URL: https://issues.apache.org/jira/browse/CB-13569
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-file
> Environment: Problem when using typescript.
> Reporter: anton deblasio
> Priority: Trivial
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> When using the typescript type file one of the enums is inverted
> the LocalFileSystem has two options PERSISTENT and TEMPORARY, these relate to the values 1 and 0 respectively. However in the typescript file they are set to 0 and 1.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org