[GitHub] [fineract] galovics commented on a diff in pull request #2819: FINERACT-1734-LoanRepaymentDue-Event-Enhancements-1

[GitBox <gi...@apache.org>]

galovics commented on code in PR #2819:
URL: https://github.com/apache/fineract/pull/2819#discussion_r1050453900


##########
fineract-avro-schemas/src/main/avro/loan/v1/RepaymentPastdueDataV1.avsc:
##########
@@ -0,0 +1,47 @@
+{
+    "name": "RepaymentPastdueDataV1",

Review Comment:
   CamelCase naming should be `RepaymentPastDueDateV1`



##########
fineract-avro-schemas/src/main/avro/loan/v1/LoanRepaymentDueDataV1.avsc:
##########
@@ -45,18 +37,18 @@
         },
         {
             "default": null,
-            "name": "totalLoanAmountDue",
+            "name": "installment",

Review Comment:
   I think let's make this not-nullable.



##########
fineract-avro-schemas/src/main/avro/loan/v1/LoanRepaymentDueDataV1.avsc:
##########
@@ -5,31 +5,23 @@
     "fields": [
         {
             "default": null,
-            "name": "id",
+            "name": "loanId",
             "type": [
                 "null",
                 "long"
             ]
         },
         {
             "default": null,
-            "name": "accountNo",
+            "name": "loanAccountNo",

Review Comment:
   I think let's make this not-nullable. (Please double-check if a loan always has accountNo)



##########
fineract-avro-schemas/src/main/avro/loan/v1/LoanRepaymentDueDataV1.avsc:
##########
@@ -5,31 +5,23 @@
     "fields": [
         {
             "default": null,
-            "name": "id",
+            "name": "loanId",

Review Comment:
   I think let's make this not-nullable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org