You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "ianmcook (via GitHub)" <gi...@apache.org> on 2023/06/08 21:36:23 UTC
[GitHub] [arrow] ianmcook opened a new pull request, #36002: GH-35669: [C++] Update to double-conversion 3.3.0, activate new flags, remove patches
ianmcook opened a new pull request, #36002:
URL: https://github.com/apache/arrow/pull/36002
[double-conversion v3.3.0](https://github.com/google/double-conversion/releases/tag/v3.3.0) adds a [new feature](https://github.com/google/double-conversion/pull/195) that allows us to remove the special code that was added to our vendored copy of double-conversion in #9816.
This PR:
* Updates vendored double-conversion to v3.3.0
* Activates the new flags `EMIT_TRAILING_DECIMAL_POINT_IN_EXPONENTIAL` and `EMIT_TRAILING_ZERO_AFTER_POINT_IN_EXPONENTIAL`
* Removes the patches in `cpp/src/arrow/vendored/double-conversion/patches`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #36002: GH-35669: [C++] Update to double-conversion 3.3.0, activate new flags, remove patches
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #36002:
URL: https://github.com/apache/arrow/pull/36002#issuecomment-1585620828
Benchmark runs are scheduled for baseline = 6808bfe3cdf5623212e575c1ec1083e194ed580c and contender = 0bbfe98386edba436b7ff42dbde4853d289808ac. 0bbfe98386edba436b7ff42dbde4853d289808ac is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/57189c864cf545b68d01d6e066615eac...8a0e74acecdf489e8e24f654bd484295/)
[Failed :arrow_down:0.68% :arrow_up:0.03%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/57804ecd69fe44819bda0ab080860c17...9b41b781e0e6484e895f75f4f99023a7/)
[Finished :arrow_down:2.94% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a32be526258f454890e91221da943f8a...eb67df9627044da29b9bc6970f101f6d/)
[Finished :arrow_down:0.33% :arrow_up:0.33%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/57fd19f9ec0a4d9aa36342710fff5087...110817f8f13a4eba8561da67d37d48f7/)
Buildkite builds:
[Finished] [`0bbfe983` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/3013)
[Failed] [`0bbfe983` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/3049)
[Finished] [`0bbfe983` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/3014)
[Finished] [`0bbfe983` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/3039)
[Finished] [`6808bfe3` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/3012)
[Finished] [`6808bfe3` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/3048)
[Finished] [`6808bfe3` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/3013)
[Finished] [`6808bfe3` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/3038)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #36002: GH-35669: [C++] Update to double-conversion 3.3.0, activate new flags, remove patches
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #36002:
URL: https://github.com/apache/arrow/pull/36002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org