DO NOT REPLY [Bug 28963] New: - One-Line Enhancement for mod_usertrack

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=28963>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28963

One-Line Enhancement for mod_usertrack

           Summary: One-Line Enhancement for mod_usertrack
           Product: Apache httpd-1.3
           Version: HEAD
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: Other
         Component: Other mods
        AssignedTo: bugs@httpd.apache.org
        ReportedBy: sabat@eloan.com


I noticed that when mod_usertrack issues a cookie, our servlet engine didn't see
it until the browser did another hit and sent the cookie back. That actually
confuses reporting for us. I've added a call to add a Cookie: header to the
incoming headers so that other handlers should see a usertrack-issued cookie as
if the browser had sent it.

This patch is against 1.3.31.

--- mod_usertrack-old.c	2004-05-13 12:06:03.000000000 -0700
+++ mod_usertrack.c	2004-05-13 12:06:09.000000000 -0700
@@ -29,7 +29,7 @@
  * If we don't find one then the user hasn't been to this site since
  * starting their browser or their browser doesn't support cookies.  So
  * we generate a unique Cookie for the transaction and send it back to
- * the browser (via a "Set-Cookie" header)
+ * the browser (via a "Set-Cookie" header).
  * Future requests from the same browser should keep the same Cookie line.
  *
  * By matching up all the requests with the same cookie you can
@@ -239,7 +239,10 @@
     ap_table_addn(r->headers_out,
                   (dcfg->style == CT_COOKIE2 ? "Set-Cookie2" : "Set-Cookie"),
                   new_cookie);
-    ap_table_setn(r->notes, "cookie", ap_pstrdup(r->pool, cookiebuf));   /* log
first time */
+    /* let other handlers see the new cookie */
+    ap_table_setn(r->headers_in, "Cookie", new_cookie);
+   /* log first time */
+    ap_table_setn(r->notes, "cookie", ap_pstrdup(r->pool, cookiebuf));
     return;
 }

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org