[GitHub] [airflow] jedcunningham commented on a diff in pull request #32724: feat(chart): Add existing secret support for PGBouncer metrics exporter.

["jedcunningham (via GitHub)" <gi...@apache.org>]

jedcunningham commented on code in PR #32724:
URL: https://github.com/apache/airflow/pull/32724#discussion_r1271251280


##########
chart/templates/secrets/pgbouncer-stats-secret.yaml:
##########


Review Comment:
   I feel like the key here should use `statsSecretKey` as well, in the off chance someone configures that but not `statsSecretName`.



##########
chart/values.schema.json:
##########
@@ -5341,6 +5341,22 @@
                             ],
                             "$ref": "#/definitions/io.k8s.api.core.v1.ResourceRequirements"
                         },
+                        "statsSecretName": {
+                            "description": "The PgBouncer Metrics Secret name.",

Review Comment:
   Can you flesh out these new descriptions a little more? Just a bit, but rehashing the key doesn't really help all that much.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org