You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2022/10/24 23:38:21 UTC
[GitHub] [datasketches-java] leerho opened a new pull request, #420: Added checkBounds on all the sketch entry points where I could find them.
leerho opened a new pull request, #420:
URL: https://github.com/apache/datasketches-java/pull/420
checkBounds(..) throws an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-java] leerho commented on a diff in pull request #420: Added checkBounds on all the sketch entry points where I could find them.
Posted by GitBox <gi...@apache.org>.
leerho commented on code in PR #420:
URL: https://github.com/apache/datasketches-java/pull/420#discussion_r1007308351
##########
src/main/java/org/apache/datasketches/fdt/PostProcessor.java:
##########
@@ -58,6 +59,8 @@ public class PostProcessor {
* @param sep the separator character
*/
public PostProcessor(final FdtSketch sketch, final Group group, final char sep) {
+ Objects.requireNonNull(sketch, "sketch must me non-null");
Review Comment:
will fix, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-java] leerho commented on pull request #420: Added checkBounds on all the sketch entry points where I could find them.
Posted by GitBox <gi...@apache.org>.
leerho commented on PR #420:
URL: https://github.com/apache/datasketches-java/pull/420#issuecomment-1289793723
This is in response to the behavior that Gian found:
https://the-asf.slack.com/archives/CP0930GKG/p1666300120496869?thread_ts=1666290716.186309&cid=CP0930GKG
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-java] leerho merged pull request #420: Added checkBounds on all the sketch entry points where I could find them.
Posted by GitBox <gi...@apache.org>.
leerho merged PR #420:
URL: https://github.com/apache/datasketches-java/pull/420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-java] AlexanderSaydakov commented on a diff in pull request #420: Added checkBounds on all the sketch entry points where I could find them.
Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov commented on code in PR #420:
URL: https://github.com/apache/datasketches-java/pull/420#discussion_r1007252654
##########
src/main/java/org/apache/datasketches/fdt/PostProcessor.java:
##########
@@ -58,6 +59,8 @@ public class PostProcessor {
* @param sep the separator character
*/
public PostProcessor(final FdtSketch sketch, final Group group, final char sep) {
+ Objects.requireNonNull(sketch, "sketch must me non-null");
Review Comment:
typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org