You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by rsafonseca <gi...@git.apache.org> on 2015/06/14 18:24:47 UTC

[GitHub] cloudstack pull request: Fix findbugs warning HE_EQUALS_USE_HASHCO...

GitHub user rsafonseca opened a pull request:

    https://github.com/apache/cloudstack/pull/439

    Fix findbugs warning HE_EQUALS_USE_HASHCODE in Ip4Address.java

    When overriding equals(), hashCode() must also be overriden do comply with the directive that equal objects must have equal hashcodes
    Without this implementation, usage of these kinds of objects in hashmaps for example, will be broken

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rsafonseca/cloudstack findbugs56

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/439.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #439
    
----
commit d567926e6425c6b66034c1c82bcd4b9ddbb38b9a
Author: Rafael da Fonseca <rs...@gmail.com>
Date:   2015-06-14T16:22:39Z

    Fix findbugs warning HE_EQUALS_USE_HASHCODE in Ip4Address.java
    When overriding equals(), hashCode() must also be overriden do comply with the directive that equal objects must have equal hashcodes
    Without this implementation, usage of these kinds of objects in hashmaps for example, will be broken

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix findbugs warning HE_EQUALS_USE_HASHCO...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/439


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---