[jira] [Commented] (DRILL-4969) Basic implementation for displaySize

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15630689#comment-15630689 ] 

ASF GitHub Bot commented on DRILL-4969:
---------------------------------------

Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/632#discussion_r86253425
  
    --- Diff: common/src/main/java/org/apache/drill/common/types/Types.java ---
    @@ -275,6 +275,84 @@ public static boolean isJdbcSignedType( final MajorType type ) {
         return isSigned;
       }
     
    +  public static int getJdbcDisplaySize(MajorType type) {
    +    if (type.getMode() == DataMode.REPEATED || type.getMinorType() == MinorType.LIST) {
    +      return 0;
    --- End diff --
    
    Why does 0 imply?


> Basic implementation for displaySize
> ------------------------------------
>
>                 Key: DRILL-4969
>                 URL: https://issues.apache.org/jira/browse/DRILL-4969
>             Project: Apache Drill
>          Issue Type: Sub-task
>          Components: Metadata
>            Reporter: Laurent Goujon
>             Fix For: 1.9.0
>
>
> display size is fixed to 10, but for most types display size is well defined as shown in the ODBC table:
> https://msdn.microsoft.com/en-us/library/ms713974(v=vs.85).aspx



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)