You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2014/11/02 02:55:04 UTC
Review Request 27482: Jobs View: Filter for tez jobs needs to work
for both
HDP 2.1 and HDP 2.2, which use tez:true, TEZ:true, respectively
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27482/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly, Srimanth Gunturi, Tom Beerbower, and Yusaku Sako.
Bugs: AMBARI-8103
https://issues.apache.org/jira/browse/AMBARI-8103
Repository: ambari
Description
-------
The behavior of the ATS server has changed in HDP 2.2, so the Jobs View needs to support either tez:true or TEZ:true.
In HDP 2.1, the following works,
http://c6407.ambari.apache.org:8188/ws/v1/timeline/HIVE_QUERY_ID?fields=events,primaryfilters,otherinfo&secondaryFilter=tez:true
In HDP 2.2, it uses TEZ:true instead.
To support both styles, the Jobs View needs to query as "tez:true,TEZ:true"
Diffs
-----
contrib/views/jobs/src/main/resources/ui/app/scripts/controllers/jobs_controller.js 6a04c98
contrib/views/jobs/src/main/resources/ui/app/scripts/helpers/ajax.js 64a8734
Diff: https://reviews.apache.org/r/27482/diff/
Testing
-------
Deployed a local VM with Ambari 1.7.0 and HDP 2.2, and created an internal ATS, and Jobs View. Then created another Ambari 1.7.0 cluster with HDP 2.1 on Google Compute Engine, also with ATS and a Jobs View.
Then, created an additional Jobs View in the local VM to point to the external VM, both instances of the Jobs View on this VM correctly showed only the Tez jobs.
```
mvn clean install
cd contrib/views/jobs
mvn clean install
```
On the VM,
```
ambari-server stop
yes | cp /vagrant/ambari/contrib/views/jobs/target/jobs-1.3.0-SNAPSHOT.jar /var/lib/ambari-server/resources/views/jobs-1.3.0-SNAPSHOT.jar
rm -rf /var/lib/ambari-server/resources/views/work/JOBS{1.0.0}/
ambari-server start
```
Thanks,
Alejandro Fernandez
Re: Review Request 27482: Jobs View: Filter for tez jobs needs to
work for
both HDP 2.1 and HDP 2.2, which use tez:true, TEZ:true, respectively
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27482/#review59518
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On Nov. 2, 2014, 1:55 a.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27482/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2014, 1:55 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Srimanth Gunturi, Tom Beerbower, and Yusaku Sako.
>
>
> Bugs: AMBARI-8103
> https://issues.apache.org/jira/browse/AMBARI-8103
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The behavior of the ATS server has changed in HDP 2.2, so the Jobs View needs to support either tez:true or TEZ:true.
> In HDP 2.1, the following works,
> http://c6407.ambari.apache.org:8188/ws/v1/timeline/HIVE_QUERY_ID?fields=events,primaryfilters,otherinfo&secondaryFilter=tez:true
> In HDP 2.2, it uses TEZ:true instead.
> To support both styles, the Jobs View needs to query as "tez:true,TEZ:true"
>
>
> Diffs
> -----
>
> contrib/views/jobs/src/main/resources/ui/app/scripts/controllers/jobs_controller.js 6a04c98
> contrib/views/jobs/src/main/resources/ui/app/scripts/helpers/ajax.js 64a8734
>
> Diff: https://reviews.apache.org/r/27482/diff/
>
>
> Testing
> -------
>
> Deployed a local VM with Ambari 1.7.0 and HDP 2.2, and created an internal ATS, and Jobs View. Then created another Ambari 1.7.0 cluster with HDP 2.1 on Google Compute Engine, also with ATS and a Jobs View.
> Then, created an additional Jobs View in the local VM to point to the external VM, both instances of the Jobs View on this VM correctly showed only the Tez jobs.
>
> ```
> mvn clean install
> cd contrib/views/jobs
> mvn clean install
> ```
>
> On the VM,
> ```
> ambari-server stop
> yes | cp /vagrant/ambari/contrib/views/jobs/target/jobs-1.3.0-SNAPSHOT.jar /var/lib/ambari-server/resources/views/jobs-1.3.0-SNAPSHOT.jar
> rm -rf /var/lib/ambari-server/resources/views/work/JOBS{1.0.0}/
> ambari-server start
> ```
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 27482: Jobs View: Filter for tez jobs needs to
work for
both HDP 2.1 and HDP 2.2, which use tez:true, TEZ:true, respectively
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27482/#review59528
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On Nov. 2, 2014, 1:55 a.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27482/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2014, 1:55 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Srimanth Gunturi, Tom Beerbower, and Yusaku Sako.
>
>
> Bugs: AMBARI-8103
> https://issues.apache.org/jira/browse/AMBARI-8103
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The behavior of the ATS server has changed in HDP 2.2, so the Jobs View needs to support either tez:true or TEZ:true.
> In HDP 2.1, the following works,
> http://c6407.ambari.apache.org:8188/ws/v1/timeline/HIVE_QUERY_ID?fields=events,primaryfilters,otherinfo&secondaryFilter=tez:true
> In HDP 2.2, it uses TEZ:true instead.
> To support both styles, the Jobs View needs to query as "tez:true,TEZ:true"
>
>
> Diffs
> -----
>
> contrib/views/jobs/src/main/resources/ui/app/scripts/controllers/jobs_controller.js 6a04c98
> contrib/views/jobs/src/main/resources/ui/app/scripts/helpers/ajax.js 64a8734
>
> Diff: https://reviews.apache.org/r/27482/diff/
>
>
> Testing
> -------
>
> Deployed a local VM with Ambari 1.7.0 and HDP 2.2, and created an internal ATS, and Jobs View. Then created another Ambari 1.7.0 cluster with HDP 2.1 on Google Compute Engine, also with ATS and a Jobs View.
> Then, created an additional Jobs View in the local VM to point to the external VM, both instances of the Jobs View on this VM correctly showed only the Tez jobs.
>
> ```
> mvn clean install
> cd contrib/views/jobs
> mvn clean install
> ```
>
> On the VM,
> ```
> ambari-server stop
> yes | cp /vagrant/ambari/contrib/views/jobs/target/jobs-1.3.0-SNAPSHOT.jar /var/lib/ambari-server/resources/views/jobs-1.3.0-SNAPSHOT.jar
> rm -rf /var/lib/ambari-server/resources/views/work/JOBS{1.0.0}/
> ambari-server start
> ```
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 27482: Jobs View: Filter for tez jobs needs to
work for
both HDP 2.1 and HDP 2.2, which use tez:true, TEZ:true, respectively
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On Nov. 2, 2014, 6:41 p.m., Yusaku Sako wrote:
> > Actually, can we add a comment saying why we are doing this double filter?
> > If not, someone later on might remove it thinking it's a typo or something.
Thanks Yusaku, I added the comment to the patch I submitted.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27482/#review59529
-----------------------------------------------------------
On Nov. 2, 2014, 1:55 a.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27482/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2014, 1:55 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Srimanth Gunturi, Tom Beerbower, and Yusaku Sako.
>
>
> Bugs: AMBARI-8103
> https://issues.apache.org/jira/browse/AMBARI-8103
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The behavior of the ATS server has changed in HDP 2.2, so the Jobs View needs to support either tez:true or TEZ:true.
> In HDP 2.1, the following works,
> http://c6407.ambari.apache.org:8188/ws/v1/timeline/HIVE_QUERY_ID?fields=events,primaryfilters,otherinfo&secondaryFilter=tez:true
> In HDP 2.2, it uses TEZ:true instead.
> To support both styles, the Jobs View needs to query as "tez:true,TEZ:true"
>
>
> Diffs
> -----
>
> contrib/views/jobs/src/main/resources/ui/app/scripts/controllers/jobs_controller.js 6a04c98
> contrib/views/jobs/src/main/resources/ui/app/scripts/helpers/ajax.js 64a8734
>
> Diff: https://reviews.apache.org/r/27482/diff/
>
>
> Testing
> -------
>
> Deployed a local VM with Ambari 1.7.0 and HDP 2.2, and created an internal ATS, and Jobs View. Then created another Ambari 1.7.0 cluster with HDP 2.1 on Google Compute Engine, also with ATS and a Jobs View.
> Then, created an additional Jobs View in the local VM to point to the external VM, both instances of the Jobs View on this VM correctly showed only the Tez jobs.
>
> ```
> mvn clean install
> cd contrib/views/jobs
> mvn clean install
> ```
>
> On the VM,
> ```
> ambari-server stop
> yes | cp /vagrant/ambari/contrib/views/jobs/target/jobs-1.3.0-SNAPSHOT.jar /var/lib/ambari-server/resources/views/jobs-1.3.0-SNAPSHOT.jar
> rm -rf /var/lib/ambari-server/resources/views/work/JOBS{1.0.0}/
> ambari-server start
> ```
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 27482: Jobs View: Filter for tez jobs needs to
work for
both HDP 2.1 and HDP 2.2, which use tez:true, TEZ:true, respectively
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27482/#review59529
-----------------------------------------------------------
Actually, can we add a comment saying why we are doing this double filter?
If not, someone later on might remove it thinking it's a typo or something.
- Yusaku Sako
On Nov. 2, 2014, 1:55 a.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27482/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2014, 1:55 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Srimanth Gunturi, Tom Beerbower, and Yusaku Sako.
>
>
> Bugs: AMBARI-8103
> https://issues.apache.org/jira/browse/AMBARI-8103
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The behavior of the ATS server has changed in HDP 2.2, so the Jobs View needs to support either tez:true or TEZ:true.
> In HDP 2.1, the following works,
> http://c6407.ambari.apache.org:8188/ws/v1/timeline/HIVE_QUERY_ID?fields=events,primaryfilters,otherinfo&secondaryFilter=tez:true
> In HDP 2.2, it uses TEZ:true instead.
> To support both styles, the Jobs View needs to query as "tez:true,TEZ:true"
>
>
> Diffs
> -----
>
> contrib/views/jobs/src/main/resources/ui/app/scripts/controllers/jobs_controller.js 6a04c98
> contrib/views/jobs/src/main/resources/ui/app/scripts/helpers/ajax.js 64a8734
>
> Diff: https://reviews.apache.org/r/27482/diff/
>
>
> Testing
> -------
>
> Deployed a local VM with Ambari 1.7.0 and HDP 2.2, and created an internal ATS, and Jobs View. Then created another Ambari 1.7.0 cluster with HDP 2.1 on Google Compute Engine, also with ATS and a Jobs View.
> Then, created an additional Jobs View in the local VM to point to the external VM, both instances of the Jobs View on this VM correctly showed only the Tez jobs.
>
> ```
> mvn clean install
> cd contrib/views/jobs
> mvn clean install
> ```
>
> On the VM,
> ```
> ambari-server stop
> yes | cp /vagrant/ambari/contrib/views/jobs/target/jobs-1.3.0-SNAPSHOT.jar /var/lib/ambari-server/resources/views/jobs-1.3.0-SNAPSHOT.jar
> rm -rf /var/lib/ambari-server/resources/views/work/JOBS{1.0.0}/
> ambari-server start
> ```
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 27482: Jobs View: Filter for tez jobs needs to
work for
both HDP 2.1 and HDP 2.2, which use tez:true, TEZ:true, respectively
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27482/#review59512
-----------------------------------------------------------
Ship it!
Ship It!
- Mahadev Konar
On Nov. 2, 2014, 1:55 a.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27482/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2014, 1:55 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Srimanth Gunturi, Tom Beerbower, and Yusaku Sako.
>
>
> Bugs: AMBARI-8103
> https://issues.apache.org/jira/browse/AMBARI-8103
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The behavior of the ATS server has changed in HDP 2.2, so the Jobs View needs to support either tez:true or TEZ:true.
> In HDP 2.1, the following works,
> http://c6407.ambari.apache.org:8188/ws/v1/timeline/HIVE_QUERY_ID?fields=events,primaryfilters,otherinfo&secondaryFilter=tez:true
> In HDP 2.2, it uses TEZ:true instead.
> To support both styles, the Jobs View needs to query as "tez:true,TEZ:true"
>
>
> Diffs
> -----
>
> contrib/views/jobs/src/main/resources/ui/app/scripts/controllers/jobs_controller.js 6a04c98
> contrib/views/jobs/src/main/resources/ui/app/scripts/helpers/ajax.js 64a8734
>
> Diff: https://reviews.apache.org/r/27482/diff/
>
>
> Testing
> -------
>
> Deployed a local VM with Ambari 1.7.0 and HDP 2.2, and created an internal ATS, and Jobs View. Then created another Ambari 1.7.0 cluster with HDP 2.1 on Google Compute Engine, also with ATS and a Jobs View.
> Then, created an additional Jobs View in the local VM to point to the external VM, both instances of the Jobs View on this VM correctly showed only the Tez jobs.
>
> ```
> mvn clean install
> cd contrib/views/jobs
> mvn clean install
> ```
>
> On the VM,
> ```
> ambari-server stop
> yes | cp /vagrant/ambari/contrib/views/jobs/target/jobs-1.3.0-SNAPSHOT.jar /var/lib/ambari-server/resources/views/jobs-1.3.0-SNAPSHOT.jar
> rm -rf /var/lib/ambari-server/resources/views/work/JOBS{1.0.0}/
> ambari-server start
> ```
>
>
> Thanks,
>
> Alejandro Fernandez
>
>