svn commit: r1625395 - /hive/branches/cbo/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java

[rh...@apache.org]

Author: rhbutani
Date: Tue Sep 16 21:13:16 2014
New Revision: 1625395

URL: http://svn.apache.org/r1625395
Log:
HIVE-8145 CBO: bail from Optiq planning if a Select list contains multiple references to the same name (Harish Butani via Ashutosh Chauhan)

Modified:
    hive/branches/cbo/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java

Modified: hive/branches/cbo/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
URL: http://svn.apache.org/viewvc/hive/branches/cbo/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java?rev=1625395&r1=1625394&r2=1625395&view=diff
==============================================================================
--- hive/branches/cbo/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java (original)
+++ hive/branches/cbo/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java Tue Sep 16 21:13:16 2014
@@ -281,6 +281,7 @@ import org.eigenbase.sql.SqlLiteral;
 import org.eigenbase.util.CompositeList;
 import org.eigenbase.util.ImmutableIntList;
 import org.eigenbase.util.Pair;
+import org.eigenbase.util.Util;
 
 import com.google.common.base.Function;
 import com.google.common.collect.ImmutableList;
@@ -13603,7 +13604,7 @@ public class SemanticAnalyzer extends Ba
     }
 
     private RelNode genSelectRelNode(List<RexNode> optiqColLst, RowResolver out_rwsch,
-        RelNode srcRel) {
+        RelNode srcRel) throws OptiqSemanticException {
       // 1. Build Column Names
       // TODO: Should this be external names
       ArrayList<String> columnNames = new ArrayList<String>();
@@ -13611,6 +13612,15 @@ public class SemanticAnalyzer extends Ba
         columnNames.add(getColumnInternalName(i));
       }
 
+      // 1.1 Ensure columnNames are unique
+      if (!Util.isDistinct(columnNames)) {
+        String msg = String.format(
+            "Select list contains multiple expressions with the same name %s."
+                + columnNames);
+        LOG.debug(msg);
+        throw new OptiqSemanticException(msg);
+      }
+
       // 2. Prepend column names with '_o_'
       /*
        * Hive treats names that start with '_c' as internalNames; so change the