[GitHub] [helix] jiajunwang commented on pull request #1123: Cleanup the persisted assignment state if no resource is on WAGED rebalancer.

[GitBox <gi...@apache.org>]

jiajunwang commented on pull request #1123:
URL: https://github.com/apache/helix/pull/1123#issuecomment-652003864


   > One high level question. `public synchronized boolean persistBaseline` or bestPossible, the synchronized is to make sure that with in a process, the persisting to ZK is guarded. Is there a case that in a single controller java process, there will be more than one waged pipeline running? My understanding is that for CRUSH full auto, we have per cluster controller pipeline. But for waged, they is only one for all clusters? Am I wrong here?
   
   You are wrong.
   1. Both WAGED and the traditional rebalancers are for each cluster.
   2. synchronized is not a must if we make the assumption that it will only be used in the WAGED rebalancer. And we are not going to change the WAGED rebalancer.
   3. Having this to protect is a nice-to-have thing. So do you suggest we remove it? I think it won't hurt.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org