You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by arucard21 <gi...@git.apache.org> on 2018/03/22 15:23:04 UTC

[GitHub] spark pull request #20882: [MINOR][CORE] Renamed long URL with shortened ver...

GitHub user arucard21 opened a pull request:

    https://github.com/apache/spark/pull/20882

    [MINOR][CORE] Renamed long URL with shortened version

    ## What changes were proposed in this pull request?
    
    We found that Scalastyle was disabled in `BlockReplicationPolicy.scala` because there was a URL in there that caused the line length to be exceeded. The URL was to a `stackexchange.com` site which actually accepts shortened versions of their normal URL as well. So we could replace the URL with the officially supported shortened version and enable Scalastyle again since this no longer exceeds the line length. I also changed the URL from `http` to `https` since the site automatically redirects to `https` anyway.
    
    ## How was this patch tested?
    
    We tested this by running `./dev/lint-scala`. First we ran it with the long URL to ensure that it actually detects the violation. Then we changed this to the shortened URL and ran it again. This time it said `Scalastyle checks passed.`
    
    ## Co-contributors:
    @chialun-yeh
    @Hrayo712
    @vpourquie

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/delftswa2018/spark scalastyle_storage

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20882.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20882
    
----
commit 3d09661f267502bdedb2e343305f375de9578d93
Author: arucard21 <ar...@...>
Date:   2018-03-22T15:13:13Z

    Renamed long URL with shortened version to avoid exceeding line length limit.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #20882: [MINOR][CORE] Renamed long URL with shortened ver...

Posted by arucard21 <gi...@git.apache.org>.
Github user arucard21 closed the pull request at:

    https://github.com/apache/spark/pull/20882


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20882: [MINOR][CORE] Renamed long URL with shortened version

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20882
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20882: [MINOR][CORE] Renamed long URL with shortened version

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20882
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20882: [MINOR][CORE] Renamed long URL with shortened version

Posted by arucard21 <gi...@git.apache.org>.
Github user arucard21 commented on the issue:

    https://github.com/apache/spark/pull/20882
  
    This change has been included in #20880 so a separate PR isn't necessary for it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org