You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by rm...@apache.org on 2010/12/13 10:54:19 UTC
svn commit: r1045048 -
/lucene/dev/trunk/lucene/src/java/org/apache/lucene/search/FieldComparator.java
Author: rmuir
Date: Mon Dec 13 09:54:19 2010
New Revision: 1045048
URL: http://svn.apache.org/viewvc?rev=1045048&view=rev
Log:
avoid synthetic method call access for things like 'bottom' in these comparators
Modified:
lucene/dev/trunk/lucene/src/java/org/apache/lucene/search/FieldComparator.java
Modified: lucene/dev/trunk/lucene/src/java/org/apache/lucene/search/FieldComparator.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/src/java/org/apache/lucene/search/FieldComparator.java?rev=1045048&r1=1045047&r2=1045048&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/src/java/org/apache/lucene/search/FieldComparator.java (original)
+++ lucene/dev/trunk/lucene/src/java/org/apache/lucene/search/FieldComparator.java Mon Dec 13 09:54:19 2010
@@ -808,20 +808,28 @@ public abstract class FieldComparator {
* than {@link TermValComparator}. For very small
* result sets it may be slower. */
public static final class TermOrdValComparator extends FieldComparator {
+ /** @lucene.internal */
+ final int[] ords;
+ /** @lucene.internal */
+ final BytesRef[] values;
+ /** @lucene.internal */
+ final int[] readerGen;
- private final int[] ords;
- private final BytesRef[] values;
- private final int[] readerGen;
-
- private int currentReaderGen = -1;
+ /** @lucene.internal */
+ int currentReaderGen = -1;
private DocTermsIndex termsIndex;
private final String field;
- private int bottomSlot = -1;
- private int bottomOrd;
- private boolean bottomSameReader;
- private BytesRef bottomValue;
- private final BytesRef tempBR = new BytesRef();
+ /** @lucene.internal */
+ int bottomSlot = -1;
+ /** @lucene.internal */
+ int bottomOrd;
+ /** @lucene.internal */
+ boolean bottomSameReader;
+ /** @lucene.internal */
+ BytesRef bottomValue;
+ /** @lucene.internal */
+ final BytesRef tempBR = new BytesRef();
public TermOrdValComparator(int numHits, String field, int sortPos, boolean reversed) {
ords = new int[numHits];
@@ -859,11 +867,13 @@ public abstract class FieldComparator {
throw new UnsupportedOperationException();
}
- // Base class for specialized (per bit width of the
- // ords) per-segment comparator. NOTE: this is messy;
- // we do this only because hotspot can't reliably inline
- // the underlying array access when looking up doc->ord
- private abstract class PerSegmentComparator extends FieldComparator {
+ /** Base class for specialized (per bit width of the
+ * ords) per-segment comparator. NOTE: this is messy;
+ * we do this only because hotspot can't reliably inline
+ * the underlying array access when looking up doc->ord
+ * @lucene.internal
+ */
+ abstract class PerSegmentComparator extends FieldComparator {
@Override
public FieldComparator setNextReader(IndexReader reader, int docBase) throws IOException {