You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/04/23 22:22:06 UTC

[GitHub] [gobblin] jack-moseley commented on a change in pull request #3271: Clear flow event after cancel

jack-moseley commented on a change in pull request #3271:
URL: https://github.com/apache/gobblin/pull/3271#discussion_r619523181



##########
File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -1200,6 +1200,7 @@ private synchronized void addFailedDag(String dagId) {
      * @param dagId
      */
     private synchronized void cleanUpDag(String dagId) {
+      this.dags.get(dagId).setFlowEvent(null);

Review comment:
       Maybe just add a comment here to explain why this is necessary




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org