You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/04/11 11:02:44 UTC
Review Request 46014: Stout:[1/2] Moved process tests to their own
file.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46014/
-----------------------------------------------------------
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
Bugs: MESOS-4471
https://issues.apache.org/jira/browse/MESOS-4471
Repository: mesos
Description
-------
Stout:[1/2] Moved process tests to their own file.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am 400c6dc451602926f93b22713af8c66d7ca59ca6
3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt c9d331df2f4496183b5734d2434413f68b9c1b4b
3rdparty/libprocess/3rdparty/stout/tests/os/process_tests.cpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 9bd34c7508cd813c5de18028956f6a740997c266
Diff: https://reviews.apache.org/r/46014/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 46014: Stout:[1/2] Moved process tests to their
own file.
Posted by Michael Park <mp...@apache.org>.
> On April 14, 2016, 9:19 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os/process_tests.cpp, lines 43-61
> > <https://reviews.apache.org/r/46014/diff/3/?file=1343687#file1343687line43>
> >
> > Do we have plans to implement this in stout?
>
> Alex Clemmer wrote:
> We do not. We could, but no one really needs it right now. Do you think we should?
No, I was just curious whether we could simply reorder a patch to avoid this.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46014/#review128989
-----------------------------------------------------------
On April 15, 2016, 8:01 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46014/
> -----------------------------------------------------------
>
> (Updated April 15, 2016, 8:01 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Bugs: MESOS-4471
> https://issues.apache.org/jira/browse/MESOS-4471
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Stout:[1/2] Moved process tests to their own file.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/Makefile.am 400c6dc451602926f93b22713af8c66d7ca59ca6
> 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt c9d331df2f4496183b5734d2434413f68b9c1b4b
> 3rdparty/libprocess/3rdparty/stout/tests/os/process_tests.cpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 9bd34c7508cd813c5de18028956f6a740997c266
>
> Diff: https://reviews.apache.org/r/46014/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 46014: Stout:[1/2] Moved process tests to their
own file.
Posted by Alex Clemmer <cl...@gmail.com>.
> On April 14, 2016, 9:19 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os/process_tests.cpp, lines 43-61
> > <https://reviews.apache.org/r/46014/diff/3/?file=1343687#file1343687line43>
> >
> > Do we have plans to implement this in stout?
We do not. We could, but no one really needs it right now. Do you think we should?
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46014/#review128989
-----------------------------------------------------------
On April 15, 2016, 8:01 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46014/
> -----------------------------------------------------------
>
> (Updated April 15, 2016, 8:01 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Bugs: MESOS-4471
> https://issues.apache.org/jira/browse/MESOS-4471
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Stout:[1/2] Moved process tests to their own file.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/Makefile.am 400c6dc451602926f93b22713af8c66d7ca59ca6
> 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt c9d331df2f4496183b5734d2434413f68b9c1b4b
> 3rdparty/libprocess/3rdparty/stout/tests/os/process_tests.cpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 9bd34c7508cd813c5de18028956f6a740997c266
>
> Diff: https://reviews.apache.org/r/46014/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 46014: Stout:[1/2] Moved process tests to their
own file.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46014/#review128989
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/libprocess/3rdparty/stout/tests/os/process_tests.cpp (lines 43 - 61)
<https://reviews.apache.org/r/46014/#comment192449>
Do we have plans to implement this in stout?
3rdparty/libprocess/3rdparty/stout/tests/os/process_tests.cpp (line 73)
<https://reviews.apache.org/r/46014/#comment192447>
Can we add a comment here about this similar to below?
```
// NOTE: `getsid` does not have a meaningful interpretation on Windows.
```
3rdparty/libprocess/3rdparty/stout/tests/os/process_tests.cpp (line 121)
<https://reviews.apache.org/r/46014/#comment192448>
Can we add a comment here about this similar to below?
```
// NOTE: `getsid` does not have a meaningful interpretation on Windows.
```
- Michael Park
On April 14, 2016, 2:06 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46014/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 2:06 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Bugs: MESOS-4471
> https://issues.apache.org/jira/browse/MESOS-4471
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Stout:[1/2] Moved process tests to their own file.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/Makefile.am 400c6dc451602926f93b22713af8c66d7ca59ca6
> 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt c9d331df2f4496183b5734d2434413f68b9c1b4b
> 3rdparty/libprocess/3rdparty/stout/tests/os/process_tests.cpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 9bd34c7508cd813c5de18028956f6a740997c266
>
> Diff: https://reviews.apache.org/r/46014/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 46014: Stout:[1/2] Moved process tests to their
own file.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46014/
-----------------------------------------------------------
(Updated April 15, 2016, 8:01 a.m.)
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
Bugs: MESOS-4471
https://issues.apache.org/jira/browse/MESOS-4471
Repository: mesos
Description
-------
Stout:[1/2] Moved process tests to their own file.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am 400c6dc451602926f93b22713af8c66d7ca59ca6
3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt c9d331df2f4496183b5734d2434413f68b9c1b4b
3rdparty/libprocess/3rdparty/stout/tests/os/process_tests.cpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 9bd34c7508cd813c5de18028956f6a740997c266
Diff: https://reviews.apache.org/r/46014/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 46014: Stout:[1/2] Moved process tests to their
own file.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46014/
-----------------------------------------------------------
(Updated April 14, 2016, 2:06 a.m.)
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
Bugs: MESOS-4471
https://issues.apache.org/jira/browse/MESOS-4471
Repository: mesos
Description
-------
Stout:[1/2] Moved process tests to their own file.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am 400c6dc451602926f93b22713af8c66d7ca59ca6
3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt c9d331df2f4496183b5734d2434413f68b9c1b4b
3rdparty/libprocess/3rdparty/stout/tests/os/process_tests.cpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 9bd34c7508cd813c5de18028956f6a740997c266
Diff: https://reviews.apache.org/r/46014/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 46014: Stout:[1/2] Moved process tests to their
own file.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46014/
-----------------------------------------------------------
(Updated April 13, 2016, 9:37 p.m.)
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
Bugs: MESOS-4471
https://issues.apache.org/jira/browse/MESOS-4471
Repository: mesos
Description
-------
Stout:[1/2] Moved process tests to their own file.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am 400c6dc451602926f93b22713af8c66d7ca59ca6
3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt c9d331df2f4496183b5734d2434413f68b9c1b4b
3rdparty/libprocess/3rdparty/stout/tests/os/process_tests.cpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 9bd34c7508cd813c5de18028956f6a740997c266
Diff: https://reviews.apache.org/r/46014/diff/
Testing
-------
Thanks,
Alex Clemmer