You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2014/12/17 20:34:41 UTC
[GitHub] incubator-brooklyn pull request: a few minor doc tweaks
GitHub user ahgittin opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/404
a few minor doc tweaks
fix link to website from guide, and mention svn commands
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/incubator-brooklyn docs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/404.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #404
----
commit 2b19dd27bea6eee19c5bcb0fcf4e216e52b4b0f3
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2014-12-17T19:33:35Z
a few minor doc tweaks
fix link to website from guide, and mention svn commands
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: a few minor doc tweaks
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/404#issuecomment-67381247
Yep, I've tested the deletion -- don't claim to fully understand it but then sed has always confused me beyond the simple case. Good idea about deletions carefully.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: a few minor doc tweaks
Posted by richardcloudsoft <gi...@git.apache.org>.
Github user richardcloudsoft commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/404#discussion_r21997884
--- Diff: docs/README.md ---
@@ -206,9 +206,13 @@ You can then preview the public site of [localhost:4000](http://localhost:4000)
_build/serve-public-site.sh
Next it is recommended to go to the SVN dir and
-review the changes using the usual `svn` commands -- `status`, `diff`, `add`, `rm`, etc:
+review the changes using the usual `svn` commands -- `status`, `diff`, `add`, `rm`, etc.
+Note in particular that deleted files need special attention (there is no analogue of
+`git add -A`!). Perhaps use:
cd ${BROOKLYN_SITE_DIR-../../incubator-brooklyn-site-public}
+ svn add * --force
+ svn rm $( svn status | sed -e '/^!/!d' -e 's/^!//' )
--- End diff --
Wow that sed command makes my head spin. Assuming that ! after a / / pair means invert the condition, then that looks feasible to me, but I hope it has been tested!
There is an argument that people should be looking *very* *carefully* at deletions as it means that we're potentially breaking external links/bookmarks. While I'm not too bothered about /v/latest, I'd suggest adding a warning here about deleting files from the main website - not a complete ban necessarily, but "proceed with care".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: a few minor doc tweaks
Posted by richardcloudsoft <gi...@git.apache.org>.
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/404#issuecomment-67380698
Looks OK to me, but I have not tested the svn deletion command. If you have, then this is clear to merge. If you're unable to test at the moment, then I can come back to this tomorrow to do some testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: a few minor doc tweaks
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/404
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---