You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@creadur.apache.org by "jbonofre (via GitHub)" <gi...@apache.org> on 2023/10/30 16:53:55 UTC
[PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
jbonofre opened a new pull request, #161:
URL: https://github.com/apache/creadur-rat/pull/161
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1377878696
##########
apache-rat-core/src/main/java/org/apache/rat/Report.java:
##########
@@ -349,29 +357,20 @@ private Report() {
* @return the IReportale instance containing the files.
*/
private static IReportable getDirectory(String baseDirectory, ReportConfiguration config) {
- try (PrintStream out = new PrintStream(config.getOutput().get())) {
- File base = new File(baseDirectory);
- if (!base.exists()) {
- out.print("ERROR: ");
- out.print(baseDirectory);
- out.print(" does not exist.\n");
- return null;
- }
+ File base = new File(baseDirectory);
Review Comment:
Catcha. Let me rebase and update accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1820642992
@Claudenw @ottlinger I added a couple of simple tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1405328109
##########
apache-rat/src/site/apt/index.apt.vm:
##########
@@ -75,17 +75,17 @@ java -jar apache-rat/target/apache-rat-${project.version}.jar
+------------------------------------------+
-usage: java -jar apache-rat/target/apache-rat-${project.version}.jar
- [options] [DIR|TARBALL]
+usage: java -jar apache-rat/target/apache-rat-CURRENT-VERSION.jar
Review Comment:
FYI, I've updated site/README with all missing options (copy/paste of the `--help` output).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
Posted by "ottlinger (via GitHub)" <gi...@apache.org>.
ottlinger commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1826819609
> @ottlinger should I update `RELEASE_NOTES.txt` ? I thought it's updated just at release time.
The txt file is generated, while the actual changelog is src/changes/changes.xml. I'll take care of that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1819439807
Rebase done, I'm adding tests now as requested by @ottlinger
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1792040351
I will but I need time : we have been hit by the storm and no electricity for now :/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
Posted by "Claudenw (via GitHub)" <gi...@apache.org>.
Claudenw commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1819489325
Looks very good to me (LVGTM?) . I await the tests with baited breath -- No I did not eat the worms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
Posted by "ottlinger (via GitHub)" <gi...@apache.org>.
ottlinger commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1787054660
Would it be possible to add a test for the newly created behaviour? (apart from the changelog entry ;))
I guess that the docs need to be updated, too:
* https://github.com/apache/creadur-rat/blob/master/apache-rat/src/site/apt/index.apt.vm
* https://github.com/apache/creadur-rat/blob/master/apache-rat/README-CLI.txt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1378419481
##########
apache-rat-core/src/main/java/org/apache/rat/Report.java:
##########
@@ -349,29 +357,20 @@ private Report() {
* @return the IReportale instance containing the files.
*/
private static IReportable getDirectory(String baseDirectory, ReportConfiguration config) {
- try (PrintStream out = new PrintStream(config.getOutput().get())) {
- File base = new File(baseDirectory);
- if (!base.exists()) {
- out.print("ERROR: ");
- out.print(baseDirectory);
- out.print(" does not exist.\n");
- return null;
- }
+ File base = new File(baseDirectory);
Review Comment:
@Claudenw is it already merged on `master` ? I tested on `master` and, even if it should with `out` is `null`, and nothing is printed on `System.out` using CLI. If I remove the lines in this change, it works. So I'm pretty sure that this part is wrong and the `Writer` is not closed cleanly.
For instance:
```
$ java -jar apache-rat-0.16-SNAPSHOT.jar /Users/jbonofre/mytest
$
```
So nothing is printed on `System.out` whereas it shoul.
It's a bug for me, fixed with my change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
Posted by "Claudenw (via GitHub)" <gi...@apache.org>.
Claudenw commented on code in PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1377861349
##########
apache-rat-core/src/main/java/org/apache/rat/Report.java:
##########
@@ -349,29 +357,20 @@ private Report() {
* @return the IReportale instance containing the files.
*/
private static IReportable getDirectory(String baseDirectory, ReportConfiguration config) {
- try (PrintStream out = new PrintStream(config.getOutput().get())) {
- File base = new File(baseDirectory);
- if (!base.exists()) {
- out.print("ERROR: ");
- out.print(baseDirectory);
- out.print(" does not exist.\n");
- return null;
- }
+ File base = new File(baseDirectory);
Review Comment:
In the new code base (after RAT-321) the ReportConfiguraiton.out is now a org.apache.commons.io.function.IOSupplier so the output does not get constructed until it is used and then it is done in the try with resource closable.
You should be able to rebase and have the "o" option create the IOSupplier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1376539769
##########
apache-rat-core/src/main/java/org/apache/rat/Report.java:
##########
@@ -349,29 +357,20 @@ private Report() {
* @return the IReportale instance containing the files.
*/
private static IReportable getDirectory(String baseDirectory, ReportConfiguration config) {
- try (PrintStream out = new PrintStream(config.getOutput().get())) {
- File base = new File(baseDirectory);
- if (!base.exists()) {
- out.print("ERROR: ");
- out.print(baseDirectory);
- out.print(" does not exist.\n");
- return null;
- }
+ File base = new File(baseDirectory);
Review Comment:
FYI, `getDirectory()` method doesn't cleanly close the `Writer` from config, e.g. we have a bug: nothing is printed to `System.out`.
This change here fix the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
Posted by "ottlinger (via GitHub)" <gi...@apache.org>.
ottlinger merged PR #161:
URL: https://github.com/apache/creadur-rat/pull/161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1825853933
@ottlinger I think we are good about this one. Can you please take a look ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
Posted by "ottlinger (via GitHub)" <gi...@apache.org>.
ottlinger commented on code in PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1405287731
##########
apache-rat/src/site/apt/index.apt.vm:
##########
@@ -75,17 +75,17 @@ java -jar apache-rat/target/apache-rat-${project.version}.jar
+------------------------------------------+
-usage: java -jar apache-rat/target/apache-rat-${project.version}.jar
- [options] [DIR|TARBALL]
+usage: java -jar apache-rat/target/apache-rat-CURRENT-VERSION.jar
Review Comment:
I've asked the same question in the other PR - could we stick with project.version here in order to generate the correct version into the file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1787582488
I will rebase and update accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
Posted by "ottlinger (via GitHub)" <gi...@apache.org>.
ottlinger commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1792037119
Please make sure to rebase as changes came in via https://github.com/apache/creadur-rat/pull/163/files - thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1793374793
I should be back online today. So I will tackle that. Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
Posted by "Claudenw (via GitHub)" <gi...@apache.org>.
Claudenw commented on code in PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1378464274
##########
apache-rat-core/src/main/java/org/apache/rat/Report.java:
##########
@@ -349,29 +357,20 @@ private Report() {
* @return the IReportale instance containing the files.
*/
private static IReportable getDirectory(String baseDirectory, ReportConfiguration config) {
- try (PrintStream out = new PrintStream(config.getOutput().get())) {
Review Comment:
This line should close the output.
##########
apache-rat-core/src/main/java/org/apache/rat/Report.java:
##########
@@ -349,29 +357,20 @@ private Report() {
* @return the IReportale instance containing the files.
*/
private static IReportable getDirectory(String baseDirectory, ReportConfiguration config) {
- try (PrintStream out = new PrintStream(config.getOutput().get())) {
- File base = new File(baseDirectory);
- if (!base.exists()) {
- out.print("ERROR: ");
- out.print(baseDirectory);
- out.print(" does not exist.\n");
- return null;
- }
+ File base = new File(baseDirectory);
Review Comment:
I see that what you have done is remove the output from the method and let the exceptions provide the info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1787127829
@ottlinger good points. Let me update the PR accordingly. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1405327832
##########
apache-rat/src/site/apt/index.apt.vm:
##########
@@ -75,17 +75,17 @@ java -jar apache-rat/target/apache-rat-${project.version}.jar
+------------------------------------------+
-usage: java -jar apache-rat/target/apache-rat-${project.version}.jar
- [options] [DIR|TARBALL]
+usage: java -jar apache-rat/target/apache-rat-CURRENT-VERSION.jar
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
Posted by "ottlinger (via GitHub)" <gi...@apache.org>.
ottlinger commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1826846100
Thanks again for this contribution @jbonofre
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
Posted by "ottlinger (via GitHub)" <gi...@apache.org>.
ottlinger commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1826461291
I'll add the changelog entry upon merging - thanks again for your contribution @jbonofre
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1813992339
Back on Rat 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1395449313
##########
apache-rat-core/src/main/java/org/apache/rat/Report.java:
##########
@@ -349,29 +357,20 @@ private Report() {
* @return the IReportale instance containing the files.
*/
private static IReportable getDirectory(String baseDirectory, ReportConfiguration config) {
- try (PrintStream out = new PrintStream(config.getOutput().get())) {
- File base = new File(baseDirectory);
- if (!base.exists()) {
- out.print("ERROR: ");
- out.print(baseDirectory);
- out.print(" does not exist.\n");
- return null;
- }
+ File base = new File(baseDirectory);
Review Comment:
I confirm that it works now on `master`. I will rebase and clean this PR accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1826572550
@ottlinger should I update `RELEASE_NOTES.txt` ? I thought it's updated just at release time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
Posted by "Claudenw (via GitHub)" <gi...@apache.org>.
Claudenw commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1792545538
I have a re based branch of JB's work. If you want I can submit that.
On Fri, Nov 3, 2023, 09:29 JB Onofré ***@***.***> wrote:
> I will but I need time : we have been hit by the storm and no electricity
> for now :/
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/creadur-rat/pull/161#issuecomment-1792040351>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AASTVHRZ64BDP5E2NPTJUU3YCSTNVAVCNFSM6AAAAAA6WLAJ6SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJSGA2DAMZVGE>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
Posted by "ottlinger (via GitHub)" <gi...@apache.org>.
ottlinger commented on code in PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1379361410
##########
apache-rat-core/src/main/java/org/apache/rat/Report.java:
##########
@@ -349,29 +357,20 @@ private Report() {
* @return the IReportale instance containing the files.
*/
private static IReportable getDirectory(String baseDirectory, ReportConfiguration config) {
- try (PrintStream out = new PrintStream(config.getOutput().get())) {
- File base = new File(baseDirectory);
- if (!base.exists()) {
- out.print("ERROR: ");
- out.print(baseDirectory);
- out.print(" does not exist.\n");
- return null;
- }
+ File base = new File(baseDirectory);
Review Comment:
@jbonofre I merged other changes concerning RAT-321. Pls retry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #161:
URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1801828395
I'm back :) I'm rebasing and fixing conflict. I will update the PR very soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@creadur.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org