You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/11 17:32:52 UTC
[GitHub] GJL commented on a change in pull request #7676:
[FLINK-11364][tests] Port TaskManagerFailsITCase to new code base
GJL commented on a change in pull request #7676: [FLINK-11364][tests] Port TaskManagerFailsITCase to new code base
URL: https://github.com/apache/flink/pull/7676#discussion_r255600139
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/minicluster/TestingMiniCluster.java
##########
@@ -66,6 +67,17 @@ public TestingMiniCluster(TestingMiniClusterConfiguration miniClusterConfigurati
return super.getDispatcherResourceManagerComponents();
}
+ @Nonnull
+ @Override
+ public CompletableFuture<Void> terminateTaskExecutor(int index) {
+ return super.terminateTaskExecutor(index);
+ }
+
+ @Override
+ public void startTaskExecutor(boolean localCommunication) throws Exception {
Review comment:
Doesn't look like user friendly API. Shouldn't `MiniCluster` set this flag depending on the configuration? Wouldn't it be enough to expose a signature such as `public void startTaskExecutor()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services