[jira] [Commented] (DRILL-5981) Add Syntax Highlighting and Error Checking to Storage Plugin Config Page

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259851#comment-16259851 ] 

ASF GitHub Bot commented on DRILL-5981:
---------------------------------------

GitHub user cgivre opened a pull request:

    https://github.com/apache/drill/pull/1043

    DRILL-5981: Add Syntax Highlighting and Error Checking to Storage Plugin Config

    This PR adds syntax highlighting to the storage plugin configuration page in the Drill web UI, as shown below.
    ![screen shot 2017-11-20 at 16 05 27](https://user-images.githubusercontent.com/5513150/33041572-c9e79f18-ce0c-11e7-8b83-0956d4d2516f.png)
    
    In addition, and the real reason I'd like to see this included is that it also incorporates error checking, again as shown below:
    
    ![screen shot 2017-11-20 at 16 05 39](https://user-images.githubusercontent.com/5513150/33041601-e39adf4c-ce0c-11e7-9514-4121fdf92ec0.png)
    
    I know there is some objection about including javascript libraries in Drill.  However, I work on a closed network and it is difficult if not impossible to build Drill from source if the libraries are not included.   I removed all JavaScript files except the bare minimum. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cgivre/drill syntax-highlighting-storage-plugin

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/1043.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1043
    
----
commit 8e1d52a3d9b08d789574e213fd07721e5b02cedf
Author: cgivre <cg...@gmail.com>
Date:   2017-11-20T20:43:23Z

    Initial Commit
    
    Final Commits
    Adds syntax highlighting and error checking to plugin configuration page.
    Removed extraneous files

----


> Add Syntax Highlighting and Error Checking to Storage Plugin Config Page
> ------------------------------------------------------------------------
>
>                 Key: DRILL-5981
>                 URL: https://issues.apache.org/jira/browse/DRILL-5981
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Web Server
>    Affects Versions: 1.12.0
>            Reporter: Charles Givre
>              Labels: easyfix
>
> When configuring storage plugins, it is easy to make a trivial mistake such as missing a comma or paren, and then spend a great deal of time trying to find that.  This PR adds syntax highlighting and error checking to the storage plugin page to prevent that. 
> Note, I work on a closed network and I have included the bare minimum of javascript libraries needed for this task.  I did include them directly in the PR because I will not be able to build Drill if I have to download them directly during the build process.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)