You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2023/01/05 02:16:12 UTC

[GitHub] [inlong] thesumery commented on a diff in pull request #7134: [INLONG-7089][Manager] Separate the concept of node tag from the node table and extract the concept of task group

thesumery commented on code in PR #7134:
URL: https://github.com/apache/inlong/pull/7134#discussion_r1062049599


##########
inlong-agent/agent-core/src/main/java/org/apache/inlong/agent/core/HeartbeatManager.java:
##########
@@ -228,7 +228,7 @@ private HeartbeatMsg buildHeartbeatMsg() {
             heartbeatMsg.setInCharges(inCharges);
         }
         if (StringUtils.isNotBlank(nodeTag)) {
-            heartbeatMsg.setNodeTag(nodeTag);
+            heartbeatMsg.setNodeLabel(nodeTag);

Review Comment:
   Table name has  alreay  embodied its meaning



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org