[GitHub] [incubator-uniffle] xianjingfeng commented on a diff in pull request #1040: [MINOR] doc: fix metrics document

["xianjingfeng (via GitHub)" <gi...@apache.org>]

xianjingfeng commented on code in PR #1040:
URL: https://github.com/apache/incubator-uniffle/pull/1040#discussion_r1275644373


##########
docs/metrics_guide.md:
##########
@@ -27,16 +27,17 @@ This document will introduce how to collect metrics from servers.
 ### Fetch metrics by REST API
 ``` shell
 # For json format
-curl http://${SERVER_HOST}:${SERVER_HTTP_PORT}/metric # fetch all metrics
-curl http://${SERVER_HOST}:${SERVER_HTTP_PORT}/metric/server # only fetch server metrics
-curl http://${SERVER_HOST}:${SERVER_HTTP_PORT}/metric/grpc # only fetch grpc metrics
-curl http://${SERVER_HOST}:${SERVER_HTTP_PORT}/metric/jvm # only fetch jvm metrics
+curl http://${SERVER_HOST}:${SERVER_HTTP_PORT}/metrics # fetch all metrics
+curl http://${SERVER_HOST}:${SERVER_HTTP_PORT}/metrics/all # fetch all metrics
+curl http://${SERVER_HOST}:${SERVER_HTTP_PORT}/metrics/server # only fetch server metrics
+curl http://${SERVER_HOST}:${SERVER_HTTP_PORT}/metrics/grpc # only fetch grpc metrics
+curl http://${SERVER_HOST}:${SERVER_HTTP_PORT}/metrics/jvm # only fetch jvm metrics
 
 # For Prometheus format
-curl http://${SERVER_HOST}:${SERVER_HTTP_PORT}/prometheus/ # fetch all metrics

Review Comment:
   This path should be supported in #1002. But i missed this. Would you mind raise another PR to fix it? @zhengchenyu 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org