You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by xyztdanid4 <gi...@git.apache.org> on 2018/03/07 10:21:06 UTC
[GitHub] metron pull request #951: Metron-1479 Introduce editorconfig, and format all...
GitHub user xyztdanid4 opened a pull request:
https://github.com/apache/metron/pull/951
Metron-1479 Introduce editorconfig, and format all of the code in alerts and config projects
It is necessary to use editorconfig, code should be look like the same in all files.
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? If not one needs to be created at [https://issues.apache.org/jira/browse/METRON-1479](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [X] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified and tested manually?
- [X] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh
```
- [ ] Have you written or updated unit tests and or integration tests to verify your changes?
- [X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xyztdanid4/metron METRON-1479
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/951.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #951
----
commit f9c2a969d359e30cb55b5012757e22c32ce57e78
Author: Daniel Toth <dt...@...>
Date: 2018-03-07T08:34:13Z
Update gitignore
commit b0cfda918e574992c94e0c890b66ce83af772837
Author: Daniel Toth <dt...@...>
Date: 2018-03-07T08:35:03Z
Integrate editorconfig
commit 588ef781295de1b141cef7d4ca12a03a8606f2c5
Author: Daniel Toth <dt...@...>
Date: 2018-03-07T08:59:17Z
Format code of metron alerts
commit e36877357e14bf12ae8ae38a5491dbb6d219f32d
Author: Daniel Toth <dt...@...>
Date: 2018-03-07T10:15:59Z
Format metron config project
----
---
[GitHub] metron issue #951: Metron-1479 Add editorconfig - create guideline for code ...
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/951
Why are there so many changes to the package locks vs. to the package files themselves?
---
[GitHub] metron issue #951: Metron-1479 Add editorconfig - create guideline for code ...
Posted by xyztdanid4 <gi...@git.apache.org>.
Github user xyztdanid4 commented on the issue:
https://github.com/apache/metron/pull/951
@ottobackwards
In my next PR the build tool will change to yarn. So package.json will be gone soon, and replaced by yarn.lock which is smaller of course.
---
[GitHub] metron issue #951: METRON-1479 Add editorconfig - create guideline for code ...
Posted by sardell <gi...@git.apache.org>.
Github user sardell commented on the issue:
https://github.com/apache/metron/pull/951
I think this is a good addition, as .editorconfig is included by default with Angular CLI-generated projects and gives consistent formatting between different contributors' editors. However, I do think this PR is really big and could be a little scary for a PR reviewer to look at. If it's easier, maybe we can break down how this could be committed and submitted for an easier review. Should be relatively easy to recreate most of this work with VS code's Format Code option.
---
[GitHub] metron issue #951: METRON-1479 Add editorconfig - create guideline for code ...
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/951
-1 as this has become an abandoned PR. I will open a request to close this PR.
---
[GitHub] metron pull request #951: METRON-1479 Add editorconfig - create guideline fo...
Posted by pono <gi...@git.apache.org>.
Github user pono closed the pull request at:
https://github.com/apache/metron/pull/951
---
[GitHub] metron issue #951: Metron-1479 Add editorconfig - create guideline for code ...
Posted by xyztdanid4 <gi...@git.apache.org>.
Github user xyztdanid4 commented on the issue:
https://github.com/apache/metron/pull/951
@ottobackwards
I am not sure, but the I guess this is the normal way of locking dependencies.
---