You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "gary murry (JIRA)" <ji...@apache.org> on 2010/01/25 21:09:34 UTC
[jira] Created: (HDFS-919) Create test to validate the
BlocksVerified metric
Create test to validate the BlocksVerified metric
-------------------------------------------------
Key: HDFS-919
URL: https://issues.apache.org/jira/browse/HDFS-919
Project: Hadoop HDFS
Issue Type: Test
Components: test
Reporter: gary murry
Just adding some tests to validate the BlocksVerified metric.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-919) Create test to validate the
BlocksVerified metric
Posted by "gary murry (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804686#action_12804686 ]
gary murry commented on HDFS-919:
---------------------------------
The attached patch adds the testing to TestDatanodeBlockScanner.java. Since there is a time interval that has to pass for the block scanner to run, I wanted to add my test in with one that already was waiting anyways.
> Create test to validate the BlocksVerified metric
> -------------------------------------------------
>
> Key: HDFS-919
> URL: https://issues.apache.org/jira/browse/HDFS-919
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Reporter: gary murry
>
> Just adding some tests to validate the BlocksVerified metric.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-919) Create test to validate the
BlocksVerified metric
Posted by "gary murry (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
gary murry updated HDFS-919:
----------------------------
Attachment: HDFS-919.patch
> Create test to validate the BlocksVerified metric
> -------------------------------------------------
>
> Key: HDFS-919
> URL: https://issues.apache.org/jira/browse/HDFS-919
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Reporter: gary murry
> Attachments: HDFS-919.patch
>
>
> Just adding some tests to validate the BlocksVerified metric.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-919) Create test to validate the
BlocksVerified metric
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805296#action_12805296 ]
Hadoop QA commented on HDFS-919:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12431382/HDFS-919.patch
against trunk revision 903381.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/104/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/104/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/104/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/104/console
This message is automatically generated.
> Create test to validate the BlocksVerified metric
> -------------------------------------------------
>
> Key: HDFS-919
> URL: https://issues.apache.org/jira/browse/HDFS-919
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Affects Versions: 0.20.2
> Reporter: gary murry
> Attachments: HDFS-919.patch, HDFS-919.patch, HDFS-919_0.20.patch, HDFS-919_2.patch
>
>
> Just adding some tests to validate the BlocksVerified metric.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-919) Create test to validate the
BlocksVerified metric
Posted by "gary murry (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
gary murry updated HDFS-919:
----------------------------
Attachment: HDFS-919_2.patch
> Create test to validate the BlocksVerified metric
> -------------------------------------------------
>
> Key: HDFS-919
> URL: https://issues.apache.org/jira/browse/HDFS-919
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Affects Versions: 0.20.2
> Reporter: gary murry
> Attachments: HDFS-919.patch, HDFS-919_2.patch
>
>
> Just adding some tests to validate the BlocksVerified metric.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-919) Create test to validate the
BlocksVerified metric
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804783#action_12804783 ]
Konstantin Boudnik commented on HDFS-919:
-----------------------------------------
+1 patch looks good. Please submit the patch for verification so it can be committed into the trunk and merged all the way back. Thanks.
> Create test to validate the BlocksVerified metric
> -------------------------------------------------
>
> Key: HDFS-919
> URL: https://issues.apache.org/jira/browse/HDFS-919
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Affects Versions: 0.20.2
> Reporter: gary murry
> Attachments: HDFS-919.patch, HDFS-919_2.patch
>
>
> Just adding some tests to validate the BlocksVerified metric.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-919) Create test to validate the
BlocksVerified metric
Posted by "gary murry (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
gary murry updated HDFS-919:
----------------------------
Attachment: HDFS-919.patch
This patch is for trunk.
> Create test to validate the BlocksVerified metric
> -------------------------------------------------
>
> Key: HDFS-919
> URL: https://issues.apache.org/jira/browse/HDFS-919
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Affects Versions: 0.20.2
> Reporter: gary murry
> Attachments: HDFS-919.patch, HDFS-919.patch, HDFS-919_0.20.patch, HDFS-919_2.patch
>
>
> Just adding some tests to validate the BlocksVerified metric.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-919) Create test to validate the
BlocksVerified metric
Posted by "gary murry (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
gary murry updated HDFS-919:
----------------------------
Status: Open (was: Patch Available)
> Create test to validate the BlocksVerified metric
> -------------------------------------------------
>
> Key: HDFS-919
> URL: https://issues.apache.org/jira/browse/HDFS-919
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Affects Versions: 0.20.2
> Reporter: gary murry
> Attachments: HDFS-919.patch, HDFS-919.patch, HDFS-919_0.20.patch, HDFS-919_2.patch
>
>
> Just adding some tests to validate the BlocksVerified metric.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-919) Create test to validate the
BlocksVerified metric
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804706#action_12804706 ]
Konstantin Boudnik commented on HDFS-919:
-----------------------------------------
+1 patch looks good, except a nit here:
- empty line mod:
{noformat}
@@ -86,7 +97,7 @@ public class TestDatanodeBlockScanner extends TestCase {
return verificationTime;
}
-
+
public void testDatanodeBlockScanner() throws IOException {
{noformat}
> Create test to validate the BlocksVerified metric
> -------------------------------------------------
>
> Key: HDFS-919
> URL: https://issues.apache.org/jira/browse/HDFS-919
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Reporter: gary murry
> Attachments: HDFS-919.patch
>
>
> Just adding some tests to validate the BlocksVerified metric.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-919) Create test to validate the
BlocksVerified metric
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805369#action_12805369 ]
Hadoop QA commented on HDFS-919:
--------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12431382/HDFS-919.patch
against trunk revision 903381.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/208/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/208/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/208/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/208/console
This message is automatically generated.
> Create test to validate the BlocksVerified metric
> -------------------------------------------------
>
> Key: HDFS-919
> URL: https://issues.apache.org/jira/browse/HDFS-919
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Affects Versions: 0.20.2
> Reporter: gary murry
> Attachments: HDFS-919.patch, HDFS-919.patch, HDFS-919_0.20.patch, HDFS-919_2.patch
>
>
> Just adding some tests to validate the BlocksVerified metric.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-919) Create test to validate the
BlocksVerified metric
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HDFS-919:
------------------------------------
Resolution: Fixed
Fix Version/s: 0.22.0
0.21.0
0.20.2
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I've just committed this to both 0.20.2, 0.21, and the trunk. Thank you Gary!
> Create test to validate the BlocksVerified metric
> -------------------------------------------------
>
> Key: HDFS-919
> URL: https://issues.apache.org/jira/browse/HDFS-919
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Affects Versions: 0.20.2
> Reporter: gary murry
> Fix For: 0.20.2, 0.21.0, 0.22.0
>
> Attachments: HDFS-919.patch, HDFS-919.patch, HDFS-919.patch, HDFS-919_0.20.patch, HDFS-919_2.patch
>
>
> Just adding some tests to validate the BlocksVerified metric.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-919) Create test to validate the
BlocksVerified metric
Posted by "gary murry (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
gary murry updated HDFS-919:
----------------------------
Attachment: HDFS-919_0.20.patch
Simply a rename to make it clear that this patch is for 20.
> Create test to validate the BlocksVerified metric
> -------------------------------------------------
>
> Key: HDFS-919
> URL: https://issues.apache.org/jira/browse/HDFS-919
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Affects Versions: 0.20.2
> Reporter: gary murry
> Attachments: HDFS-919.patch, HDFS-919_0.20.patch, HDFS-919_2.patch
>
>
> Just adding some tests to validate the BlocksVerified metric.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-919) Create test to validate the
BlocksVerified metric
Posted by "gary murry (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804770#action_12804770 ]
gary murry commented on HDFS-919:
---------------------------------
I made Cos' changes. Thanks
> Create test to validate the BlocksVerified metric
> -------------------------------------------------
>
> Key: HDFS-919
> URL: https://issues.apache.org/jira/browse/HDFS-919
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Affects Versions: 0.20.2
> Reporter: gary murry
> Attachments: HDFS-919.patch, HDFS-919_2.patch
>
>
> Just adding some tests to validate the BlocksVerified metric.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-919) Create test to validate the
BlocksVerified metric
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804724#action_12804724 ]
Konstantin Boudnik commented on HDFS-919:
-----------------------------------------
One more thing: it won't hurt to add some meaningful message to the following assert statement:
{noformat}
+ assertEquals(1, blocksValidated);
+ break;
{noformat}
this will facilitate the failures analysis.
> Create test to validate the BlocksVerified metric
> -------------------------------------------------
>
> Key: HDFS-919
> URL: https://issues.apache.org/jira/browse/HDFS-919
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Affects Versions: 0.20.2
> Reporter: gary murry
> Attachments: HDFS-919.patch
>
>
> Just adding some tests to validate the BlocksVerified metric.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-919) Create test to validate the
BlocksVerified metric
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HDFS-919:
------------------------------------
Attachment: HDFS-919.patch
Exactly as before but with one empty line mod removed. I've done it myself in order to speed the commit.
> Create test to validate the BlocksVerified metric
> -------------------------------------------------
>
> Key: HDFS-919
> URL: https://issues.apache.org/jira/browse/HDFS-919
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Affects Versions: 0.20.2
> Reporter: gary murry
> Attachments: HDFS-919.patch, HDFS-919.patch, HDFS-919.patch, HDFS-919_0.20.patch, HDFS-919_2.patch
>
>
> Just adding some tests to validate the BlocksVerified metric.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-919) Create test to validate the
BlocksVerified metric
Posted by "gary murry (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
gary murry updated HDFS-919:
----------------------------
Status: Patch Available (was: Open)
> Create test to validate the BlocksVerified metric
> -------------------------------------------------
>
> Key: HDFS-919
> URL: https://issues.apache.org/jira/browse/HDFS-919
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Affects Versions: 0.20.2
> Reporter: gary murry
> Attachments: HDFS-919.patch, HDFS-919.patch, HDFS-919_0.20.patch, HDFS-919_2.patch
>
>
> Just adding some tests to validate the BlocksVerified metric.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-919) Create test to validate the
BlocksVerified metric
Posted by "gary murry (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805315#action_12805315 ]
gary murry commented on HDFS-919:
---------------------------------
These results look to be unrelated to my patch. The reference two other patches. I am going to resubmit to see if that clears up the issue.
> Create test to validate the BlocksVerified metric
> -------------------------------------------------
>
> Key: HDFS-919
> URL: https://issues.apache.org/jira/browse/HDFS-919
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Affects Versions: 0.20.2
> Reporter: gary murry
> Attachments: HDFS-919.patch, HDFS-919.patch, HDFS-919_0.20.patch, HDFS-919_2.patch
>
>
> Just adding some tests to validate the BlocksVerified metric.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-919) Create test to validate the
BlocksVerified metric
Posted by "gary murry (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
gary murry updated HDFS-919:
----------------------------
Status: Patch Available (was: Open)
> Create test to validate the BlocksVerified metric
> -------------------------------------------------
>
> Key: HDFS-919
> URL: https://issues.apache.org/jira/browse/HDFS-919
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Affects Versions: 0.20.2
> Reporter: gary murry
> Attachments: HDFS-919.patch, HDFS-919.patch, HDFS-919_0.20.patch, HDFS-919_2.patch
>
>
> Just adding some tests to validate the BlocksVerified metric.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-919) Create test to validate the
BlocksVerified metric
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853953#action_12853953 ]
Hudson commented on HDFS-919:
-----------------------------
Integrated in Hadoop-Hdfs-trunk #275 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/275/])
> Create test to validate the BlocksVerified metric
> -------------------------------------------------
>
> Key: HDFS-919
> URL: https://issues.apache.org/jira/browse/HDFS-919
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Affects Versions: 0.20.2
> Reporter: gary murry
> Fix For: 0.20.2, 0.21.0, 0.22.0
>
> Attachments: HDFS-919.patch, HDFS-919.patch, HDFS-919.patch, HDFS-919_0.20.patch, HDFS-919_2.patch
>
>
> Just adding some tests to validate the BlocksVerified metric.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-919) Create test to validate the
BlocksVerified metric
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805717#action_12805717 ]
Hudson commented on HDFS-919:
-----------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #182 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/182/])
. Create test to validate the BlocksVerified metric. Contributed by Gary Murry.
> Create test to validate the BlocksVerified metric
> -------------------------------------------------
>
> Key: HDFS-919
> URL: https://issues.apache.org/jira/browse/HDFS-919
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Affects Versions: 0.20.2
> Reporter: gary murry
> Fix For: 0.20.2, 0.21.0, 0.22.0
>
> Attachments: HDFS-919.patch, HDFS-919.patch, HDFS-919.patch, HDFS-919_0.20.patch, HDFS-919_2.patch
>
>
> Just adding some tests to validate the BlocksVerified metric.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-919) Create test to validate the
BlocksVerified metric
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HDFS-919:
------------------------------------
Affects Version/s: 0.20.2
This clearly has to be committed into 0.20 and above.
> Create test to validate the BlocksVerified metric
> -------------------------------------------------
>
> Key: HDFS-919
> URL: https://issues.apache.org/jira/browse/HDFS-919
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Affects Versions: 0.20.2
> Reporter: gary murry
> Attachments: HDFS-919.patch
>
>
> Just adding some tests to validate the BlocksVerified metric.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.